Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding refactored packager, adding pbss configs, removal of mumbai ( … #1311

Merged
merged 11 commits into from
Oct 10, 2024

Conversation

djpolygon
Copy link
Contributor

Description

New version of packager, binary and profiles are discreet tasks for each network.
Updated to generate control file with TAG
Removal of mumbai, now sunset by Amoy
Addition of PBSS profiles
Checksum for each package built
MaxPeer count bumped to 200 for node types per recommendation.

Changes

  • [ x] Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • [ x] New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)
  • Changes only for a subset of nodes

Breaking changes

Please complete this section if any breaking changes have been made, otherwise delete it

Nodes audience

In case this PR includes changes that must be applied only to a subset of nodes, please specify how you handled it (e.g. by adding a flag with a default value...)

Checklist

  • [ x] I have added at least 2 reviewer or the whole pos-v1 team
  • I have added sufficient documentation in code
  • [ x] I will be resolving comments - if any - by pushing each fix in a separate commit and linking the commit hash in the comment reply
  • Created a task in Jira and informed the team for implementation in Erigon client (if applicable)
  • Includes RPC methods changes, and the Notion documentation has been updated

Cross repository changes

  • This PR requires changes to heimdall
    • In case link the PR here:
  • This PR requires changes to matic-cli
    • In case link the PR here:

Testing

  • I have added unit tests
  • I have added tests to CI
  • I have tested this code manually on local environment
  • I have tested this code manually on remote devnet using express-cli
  • I have tested this code manually on mumbai/amoy
  • I have created new e2e tests into express-cli

Manual tests

Please complete this section with the steps you performed if you ran manual tests for this functionality, otherwise delete it

Additional comments

Please post additional comments in this section if you have them, otherwise delete it

@djpolygon djpolygon requested review from pratikspatil024, marcello33 and cffls and removed request for pratikspatil024 August 21, 2024 20:59
Copy link
Contributor

@cffls cffls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If possible, could you please provide some information about how these changes were tested in the description of the PR?

.github/workflows/packager_deb.yml Outdated Show resolved Hide resolved
@djpolygon
Copy link
Contributor Author

djpolygon commented Aug 22, 2024

If possible, could you please provide some information about how these changes were tested in the description of the PR?

Sure, packages were built and installed internally on test nodes. PBSS config changes were based on details provided by the POS team for the specific profiles along with the maxpeer count increase from 50-> 200

@djpolygon djpolygon mentioned this pull request Sep 20, 2024
14 tasks
@djpolygon djpolygon requested review from a team and removed request for anshalshukla September 23, 2024 13:45
@djpolygon djpolygon requested a review from a team October 2, 2024 18:20
@djpolygon djpolygon changed the base branch from develop to v1.5.0-candidate October 9, 2024 14:50
@djpolygon djpolygon merged commit 2cae584 into v1.5.0-candidate Oct 10, 2024
8 of 9 checks passed
@djpolygon djpolygon deleted the djpolygon/SPEC-154 branch October 10, 2024 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants