Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improves Seraphic Sraf browser detection #6538

Merged
merged 2 commits into from
Dec 17, 2020
Merged

Improves Seraphic Sraf browser detection #6538

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a36a591
Improves Seraphic Sraf browser detection
liviuconcioiu Dec 17, 2020
8f38a37
Correct fixture and add it to Chrome family
liviuconcioiu Dec 17, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Parser/Client/Browser.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -343,7 +343,7 @@ class Browser extends AbstractClientParser
'CL', 'SU', 'EU', 'UB', 'LO', 'VG', 'TV', 'A0', '1B',
'S4', 'EE', 'AE', 'VM', 'O0', 'TG', 'GB', 'SY', 'HH',
'YJ', 'LL', 'TU', 'XV', 'C2', 'QU', 'YN', 'JB', 'MR',
'S6', '7S', 'NM', 'PB', 'UR', 'NR', 'SG', 'S8',
'S6', '7S', 'NM', 'PB', 'UR', 'NR', 'SG', 'S8', 'SS',
],
'Firefox' => [
'FF', 'FE', 'FM', 'SX', 'FB', 'PX', 'MB', 'EI', 'WF',
Expand Down
4 changes: 2 additions & 2 deletions Tests/fixtures/tv.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1354,8 +1354,8 @@
platform: x64
client:
type: browser
name: Chrome
version: "30.0.1599.114"
name: Seraphic Sraf
version: "3.0"
engine: Blink
engine_version: ""
device:
Expand Down
14 changes: 7 additions & 7 deletions regexes/client/browsers.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,13 @@
# @license http://www.gnu.org/licenses/lgpl.html LGPL v3 or later
###############

#Seraphic Sraf (https://www.seraphic-corp.com/)
- regex: 'Sraf(?:[/ ](\d+[\.\d]+))?'
name: 'Seraphic Sraf'
version: '$1'
engine:
default: 'Blink'

# Seewo Browser (http://e.seewo.com/)
- regex: 'SeewoBrowser/(?:(\d+[\.\d]+))?'
name: 'Seewo Browser'
Expand Down Expand Up @@ -1740,13 +1747,6 @@
name: 'SEMC-Browser'
version: '$1'

#Seraphic Sraf
- regex: 'Sraf(?:[/ ](\d+[\.\d]+))?'
name: 'Seraphic Sraf'
version: '$1'
engine:
default: 'Blink'

#Shiira
- regex: 'Shiira(?:[/ ](\d+[\.\d]+))?'
name: 'Shiira'
Expand Down