Skip to content

Commit

Permalink
fix uninstall e2e test failure
Browse files Browse the repository at this point in the history
  • Loading branch information
diosmosis committed Dec 25, 2024
1 parent c33402c commit 5ceae8f
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 3 deletions.
6 changes: 6 additions & 0 deletions tests/e2e-uninstall/get-matomo-tables.php
Original file line number Diff line number Diff line change
Expand Up @@ -19,13 +19,19 @@
exit;
}

$multi = isset( $_GET['multi'] ) ? ( (int) $_GET['multi'] ) : 0;
if ( $multi ) {
$dbname = preg_replace( '/_multi$/', '', $dbname );
}

$pdo = new \PDO( "mysql:host=$host;dbname={$dbname}", 'root', 'pass' );
$query = $pdo->prepare( 'SHOW TABLES' );
$query->execute();

$tables = $query->fetchAll( \PDO::FETCH_COLUMN );
echo json_encode(
[
'get' => $_GET,
'dbname' => $dbname,
'tables' => $tables,
]
Expand Down
5 changes: 2 additions & 3 deletions tests/e2e-uninstall/uninstall.e2e.ts
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,7 @@ describe('MWP Uninstall', () => {
});

async function getTablesInstalled(): Promise<any> {
console.log('root url: ' + `${await Website.rootUrl()}/matomo-for-wordpress/tests/e2e-uninstall/get-matomo-tables.php`);
let result: any = await fetch(`${await Website.rootUrl()}/matomo-for-wordpress/tests/e2e-uninstall/get-matomo-tables.php`);
let result: any = await fetch(`${await Website.rootUrl()}/matomo-for-wordpress/tests/e2e-uninstall/get-matomo-tables.php?multi=0`);
result = await result.text();
try {
result = JSON.parse(result);
Expand Down Expand Up @@ -67,7 +66,7 @@ describe('MWP Uninstall', () => {
expect(result.tables).toBeInstanceOf(Array); // sanity check

console.log(`result.dbname is: ${result.dbname}`);

console.log(`result.get is ${result.get}`);
let tables = result.tables;
tables = tables.filter((t: string) => t.includes('matomo'));
expect(tables).toEqual([]); // check there are no tables with "matomo" in the name
Expand Down

0 comments on commit 5ceae8f

Please sign in to comment.