Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

throw different exception if token is missing vs token is invalid #884

Merged
merged 1 commit into from
Sep 28, 2023

Conversation

diosmosis
Copy link
Member

@diosmosis diosmosis commented Sep 27, 2023

Description:

When debugging the occurrence of token auth issues in API requests for users, it can be helpful to know if the token auth is just missing for the request (say some wordpress security plugin removes it for some reason) or if it's actually invalid.

Also includes a new .editorconfig to change tab type for the Wordpress matomo plugin code which uses spaces.

Refs #820

Review

…se .editorconfig to change tab type for Wordpress matomo plugin
@diosmosis diosmosis added the Needs Review For pull requests that need a code review. label Sep 27, 2023
@diosmosis diosmosis requested a review from tsteur September 27, 2023 06:10
Copy link
Member

@tsteur tsteur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That will be useful 👍

@diosmosis diosmosis merged commit 2ba8c41 into develop Sep 28, 2023
6 of 10 checks passed
@diosmosis diosmosis deleted the better-token-auth-message branch September 28, 2023 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Review For pull requests that need a code review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants