Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow loading the woocommerce premium plugin in the local dev environment #901

Merged
merged 1 commit into from
Oct 16, 2023

Conversation

diosmosis
Copy link
Member

Description:

As title, since work on that plugin will be managed as part of this project.

Review

@diosmosis diosmosis added the Needs Review For pull requests that need a code review. label Oct 14, 2023
@diosmosis diosmosis requested a review from tsteur October 14, 2023 03:44
Copy link
Member

@tsteur tsteur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@diosmosis overall looks god. The only thing I wonder is that Matomo for WordPress already has WooCommerce integrated. Meaning that plugin may technically not needed and it's meant to be used together with "Connect Matomo".

I suppose the plugin is there so we can enable/disable it as needed? I suppose there is no downside even if both were running at the same time as long as Ecommerce tracking is disabled in Matomo for WordPress and shouldn't cause any duplicate tracking or something.

Feel free to merge

@diosmosis
Copy link
Member Author

👍 This is just for local dev so it would be easier to develop with the premium plugin. Having to make change, create a zip, upload it, then repeat is a lot, and since I'm maintaining both, might as well put it in the same local dev environment.

@diosmosis diosmosis merged commit 59c29a5 into develop Oct 16, 2023
6 of 10 checks passed
@diosmosis diosmosis deleted the localdev-woopiwik branch October 16, 2023 00:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Review For pull requests that need a code review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants