Update target SDK to version 34 (#5456)

* Update target SDK to version 34

* update version codes

* improve instructions to build release file

* fix Try It feature no longer working

* Fix some errors/crashes on android

* fix search bar is small and not cancelling

* fix image detail graph misplaced

* fix graph detail not shown on tablet

* fix account gets deleted no matter if you select yes or no

* refs #5457 fix some translations of choose date

* Update release number

README.md

@@ -41,6 +41,12 @@ If you don't have Titanium SDK installed on your system have a look at [From zer
 ### Build the app
 * `ti build -p ios` or `ti build -p android` to build the app
 
+### Build for release on Android
+
+```
+ti build -p android -b -K $pathKeyStoreFile -P $keystorePassword -L $alias -D production -T dist-playstore -O $outputDirectory 
+```
+
 ## Contact
 
 https://matomo.org

app/controllers/account_creator_footer.js

@@ -19,7 +19,7 @@ function tryIt ()
 
     require('login').login(
         accounts,
-        'https://demo.matomo.org',
+        'https://demo.matomo.cloud',
         '',
         '',
         ''

app/controllers/accounts.js

@@ -73,18 +73,17 @@ function deleteAccountIfUserConfirmsButNotOniOS(event)
         cancel: 1,
         buttonNames: [L('General_Yes'), L('General_No')],
         selectedIndex: 1,
-        destructive: 0,
         title: L('Mobile_ConfirmRemoveAccount')
     });
 
     dialog.addEventListener('click', function (clickEvent) {
-        if (!clickEvent ||
-            clickEvent.cancel === clickEvent.index ||
-            true === clickEvent.cancel) {
-
+        if (!clickEvent) {
             return;
         }
 
+        if (clickEvent.index == 1) {
+            return;
+        }
         deleteAccount(event);
     });
 

app/controllers/all_websites_dashboard.js

@@ -184,17 +184,19 @@ function showLoadingMessage()
     $.loading.show();
 }
 
-function cancelSearchWebsite()
+function changeSearchWebsite()
 {
     if (!$.searchBar) {
 
         return;
     }
 
-    $.searchBar.value = '';
-    $.searchBar.blur();
+    if (!$.searchBar.value) {
 
-    fetchListOfAvailableWebsites();
+        $.searchBar.blur();
+
+        fetchListOfAvailableWebsites();
+    }
 }
 
 function getSearchText()

app/controllers/graph_detail.js

@@ -21,6 +21,7 @@ graphSwitcher.on('close', close);
 
 graphSwitcher.on('switch', function () {
     var url = getGraphUrlWithSize(getPictureWidth(), getPictureHeight());
+    console.debug('imageDetailUrlWithSize', url);
     $.graphWidget.loadImage(url);
 });
 
@@ -81,7 +82,7 @@ function getPictureHeight() {
     } else {
         pictureHeight = height - 20; // 10px space left and right
     }
-    
+
     return pictureHeight;
 }
 
@@ -158,11 +159,15 @@ function getImageView(url, width, height) {
     return Alloy.createWidget('org.piwik.imageview', 'widget', options);
 }
 
-var pictureWidth     = getPictureWidth();
-var pictureHeight    = getPictureHeight();
-var graphUrlWithSize = getGraphUrlWithSize(pictureWidth, pictureHeight);
+function onPostlayout() {
 
-$.graphWidget.loadImage(graphUrlWithSize);
+    var pictureWidth     = getPictureWidth();
+    var pictureHeight    = getPictureHeight();
+    var graphUrlWithSize = getGraphUrlWithSize(pictureWidth, pictureHeight);
+
+    console.debug('imageDetailUrlWithSize', graphUrlWithSize);
+    $.graphWidget.loadImage(graphUrlWithSize);
+}
 
 if (isTablet) {
 
@@ -185,7 +190,6 @@ if (isTablet) {
         try {
             var pictureWidth  = getOrientationSpecificWidth();
             var pictureHeight = getOrientationSpecificHeight();
-
             $.index.remove($.graph);
             $.graph = null;
 
@@ -260,4 +264,4 @@ function open()
     }
 }
 
-exports.open = open;
+exports.open = open;

app/controllers/report_without_dimension.js

@@ -274,7 +274,7 @@ function fixVerticalSeparatorHeight()
     var height = parseInt($.dimensions.size.height, 10);
 
     if (5 < height) {
-        $.verticalSeparator.setHeight($.dimensions.size.height);
+        $.verticalSeparator.height = ($.dimensions.size.height);
     }
 }
 

app/controllers/visitor.js

@@ -14,7 +14,7 @@ var args    = arguments[0] || {};
 var visitor = args.visitor;
 
 var accountModel = require('session').getAccount();
-var accessUrl    = accountModel ? accountModel.getBasePath() : 'https://demo.matomo.org/';
+var accessUrl    = accountModel ? accountModel.getBasePath() : 'https://demo.matomo.cloud/';
 
 var rows = [];
 

app/controllers/visitor_overview.js

@@ -11,7 +11,7 @@ function L(key)
 }
 
 var args      = arguments[0] || {};
-var accessUrl = args.account ? args.account.getBasePath() : 'https://demo.matomo.org/';
+var accessUrl = args.account ? args.account.getBasePath() : 'https://demo.matomo.cloud/';
 var visitor   = args.visitor || null;
 
 function goalConversionDescription(visitor)
@@ -132,4 +132,4 @@ function updateDisplayedValues(visitor)
     }
 }
 
-updateDisplayedValues(visitor);
+updateDisplayedValues(visitor);

app/lib/Piwik/Network/HttpRequest.js

@@ -159,7 +159,7 @@ HttpRequest.prototype.handle = function () {
     var settings    = Alloy.createCollection('AppSettings').settings();
     var validateSsl = settings.shouldValidateSsl();
 
-    this.xhr = Ti.Network.createHTTPClient({validatesSecureCertificate: validateSsl, enableKeepAlive: false});
+    this.xhr = Ti.Network.createHTTPClient({validatesSecureCertificate: !!validateSsl, enableKeepAlive: false});
     var that = this;
 
     this.xhr.onload  = function () { that.load(this); that = null; };

app/lib/i18n/default.js

@@ -134,7 +134,7 @@ module.exports = {
     Mobile_Advanced:                                                    'Advanced',
     Mobile_AnonymousAccess:                                             'Anonymous access',
     Mobile_AnonymousTracking:                                           'Anonymous tracking',
-    Mobile_AccessUrlLabel:                                              'URL eg https://demo.matomo.org',
+    Mobile_AccessUrlLabel:                                              'URL eg https://demo.matomo.cloud',
     Mobile_AskForAnonymousTrackingPermission:                           'When enabled, Matomo Mobile will send anonymous usage data to matomo.org. The intent is to use this data to help Matomo Mobile developers better understand how the app is used. Information sent is: menus and settings clicked on, OS name and version, any error displayed in Matomo Mobile. We will NOT track any of your analytics data. This anonymous data will never be made public. You can disable/enable anonymous tracking in Settings at any time.',
     Mobile_ChooseHttpTimeout:                                           'Choose HTTP timeout value',
     Mobile_ChooseMetric:                                                'Choose Metric',