Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ok button text in privacy settings #22902

Merged
merged 2 commits into from
Jan 6, 2025
Merged

Fix ok button text in privacy settings #22902

merged 2 commits into from
Jan 6, 2025

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented Dec 29, 2024

Description:

fixes #22901

Review

Sorry, something went wrong.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
fixes #22901
@sgiehl sgiehl added the Needs Review PRs that need a code review label Dec 29, 2024
@sgiehl sgiehl added this to the 5.3.0 milestone Dec 29, 2024
Copy link
Contributor

@michalkleiner michalkleiner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change itself is fine and the failing test is unrelated.

@michalkleiner michalkleiner merged commit c2010d1 into 5.x-dev Jan 6, 2025
24 of 26 checks passed
@michalkleiner michalkleiner deleted the m22901 branch January 6, 2025 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Review PRs that need a code review
Projects
None yet
4 participants