Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correcting plural of "Mediums" to "Media" #154

Open
wants to merge 2 commits into
base: 5.x-dev
Choose a base branch
from

Conversation

terpfear
Copy link

Description:

This change comes at the request of our marketing team, who are in charge of all the language and grammar on our website. They have pointed out that the correct plural of "Mediums" is "Media" in this context.

Review

@AltamashShaikh
Copy link
Contributor

@terpfear Thankyou for your PR, but Campaign Medium is the most widely used and generic term, I am not sure if we will be able to merge this PR.

@sgiehl
Copy link
Member

sgiehl commented Jun 28, 2024

@AltamashShaikh The plural can indeed be mediums or media depending on the context. Might be good to maybe ask Gillian for advice.

@AltamashShaikh
Copy link
Contributor

@AltamashShaikh The plural can indeed be mediums or media depending on the context. Might be good to maybe ask Gillian for advice.

@sgiehl After checking with Gillian, she is also of opinion of not changing it to Media.

"I understand that media can be plural for medium based on context, but changing to Campaign Media here does not fit and could mean something else entirely - if there was going to be a change, I would rather just change Mediums to Medium. or keep all of these labels singular"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants