Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding new tracking type to the Matomo Tag #575

Open
wants to merge 6 commits into
base: 5.x-dev
Choose a base branch
from

Conversation

tomper00
Copy link
Contributor

Adding new tracking type to the Matomo Tag.

Description:

This adds a new tracking type Search to the Matomo Tag

I would say that the best case to use this feature is when you do not have search parameters in the URL or when you want to add search count to your searches.

You should also set up Variables to handle the inputs (since search is always dynamic).

matomo-search-tracking

Review

Adding new tracking type to the Matomo Tag.
Fixing tests to match new translations and also adding a new db update script
Copy link
Contributor

@snake14 snake14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good. I think that only a few little changes are needed to get the tests passing. After that, we can try and do some functional testing. Any concerns @AltamashShaikh ?

Template/Tag/MatomoTag.php Show resolved Hide resolved
@AltamashShaikh
Copy link
Contributor

Looks pretty good. I think that only a few little changes are needed to get the tests passing. After that, we can try and do some functional testing. Any concerns @AltamashShaikh ?

@snake14 No concern if its working as expected 👍

@snake14
Copy link
Contributor

snake14 commented Nov 21, 2022

@tomper00 Looks like you've just about got the builds fixed. You have a SearchCount instead of searchCount in plugins/TagManager/tests/System/processed/test_webContext__TagManager.getAvailableTagTypesInContext.xml and it looks like searchCategory and searchCount need to be updated with the false default value in plugins/TagManager/tests/System/processed/test___TagManager.exportContainerVersion_site_default_container.xml.

@snake14
Copy link
Contributor

snake14 commented Nov 23, 2022

@tomper00 Thank you for getting the tests passing.

I wonder if we should change this branch to Matomo version 5 like your other open PR. @AltamashShaikh ?

@AltamashShaikh AltamashShaikh changed the base branch from 4.x-dev to 5.x-dev November 24, 2022 02:18
@AltamashShaikh
Copy link
Contributor

@snake14 Updated base branch to 5.x-dev

/**
* Update for version 4.12.4-b1.
*/
class Updates_4_12_4_b3 extends PiwikUpdates
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tomper00 Sorry but can you update this migration class name as per your other PR suggestion ?

@AltamashShaikh
Copy link
Contributor

@tomper00 Any updates ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants