added Stairs to basic plot types

[mariamalykh]

PR summary

PR checklist

• "closes [Doc]: More plot types? #23204" is in the body of the PR description to link the related issue
• new and changed code is tested
• Plotting related features are demonstrated in an example
• New Features and API Changes are noted with a directive and release note
• Documentation complies with general and docstring guidelines

[github-actions]

Thank you for opening your first PR into Matplotlib!

If you have not heard from us in a while, please feel free to ping @matplotlib/developers or anyone who has commented on the PR. Most of our reviewers are volunteers and sometimes things fall through the cracks.

You can also join us on gitter for real-time discussion.

For details on testing, writing docs, and our review process, please see the developer guide

We strive to be a welcoming and open project. Please follow our Code of Conduct.

[jklymak]

Thanks for this - however, plot-types is purposely not to be exhaustive - if I were to do anything, it would be to replace step with stairs, but I don't think we should have both as they are too similar.

[mariamalykh]

Yes, but I can't do it with my access. Can you delete step plot type?

[story645]

@mariamalykh you should be able to delete it locally on your working branch and push that change up. If you do, then the file will be deleted once your PR is merged.

Though I disagree with deleting it & would like plot types to be a bit more comprehensive with respect to the plotting methods - imshow and pcolormesh also produce similar plots and the difference is in how the data is structured just like stairs vs. step and imshow and pcolormesh are in the plot gallery.

[mariamalykh]

@mariamalykh you should be able to delete it locally on your working branch and push that change up. If you do, then the file will be deleted once your PR is merged.

Though I disagree with deleting it & would like plot types to be a bit more comprehensive with respect to the plotting methods - imshow and pcolormesh also produce similar plots and the difference is in how the data is structured just like stairs vs. step and imshow and pcolormesh are in the plot gallery.

maybe that's why we should accept the 1st variant of the request, it has passed all the autotests

[jklymak]

Stairs and step are the same, just with different ways of specifying the step edges. The imshow and pcolormesh are similar, but pcolormesh is much more flexible on the spacing and location of the x and y grids. If someone proposed adding pcolor or pcolorfast to the basic plot types I would also object that they are the same as pcolormesh and are not needed. In my opinion having stair and step on this page just clutters the page and is more mystifying than helpful.

I think that both here and in the method documentation both methods should refer to each other.

[rcomer]

@mariamalykh your branch is quite far behind our repo’s main branch. The file you are trying to delete had been updated here since you created your fork. You will need to rebase to pick up those changes, and then the deletion should work.

[jklymak]

Remember to do "git rm" or "git mv" so git knows about the change.

[rcomer]

There is a related PR in the cheat sheets: matplotlib/cheatsheets#112

[rcomer]

@mariamalykh are you still interested in working on this? Can we help you with anything?