Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC: try using non-breaking spaces in nav bar #91

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

tacaswell
Copy link
Member

This may help the responsive layout to avoid things like matplotlib/matplotlib#28832

This may help the responsive layout to avoid things like
matplotlib/matplotlib#28832
@timhoffm
Copy link
Member

You could more easily achieve this using text-wrap: nowrap; CSS.

That said, text wrapping is not the problem of #28832. In fact it rather helps a bit. The main issue that there is not enough space for all the content when shrinking the page width. This leads to wrapping, and the wrapping that consumes the most vertical space are the icons:

grafik

To fix this, we either need to hide the menubar earlier (i.e. override this setting

https://github.com/pydata/pydata-sphinx-theme/blob/7e20e75d96845ff704b47ad057b5802078ff1125/src/pydata_sphinx_theme/assets/styles/variables/_layout.scss#L21

) or, - more elegant but also more complex - we have to somehow condense the icons (e.g. into a dropdown) for the intermediate widths.

@jklymak
Copy link
Member

jklymak commented Sep 18, 2024

We should probably just adjust the width for the collapse? I'm sure they chose a width based on their toolbar and ours is pretty "feature full"/"cluttered"

@timhoffm
Copy link
Member

We should probably just adjust the width for the collapse?

That's the sass setting I've linked above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants