Add a dry run flag to ensure we don't accidentally send out invites when testing #209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Half-Shot
requested changes
Jan 15, 2024
src/invites.ts
Outdated
| @@ -80,7 +80,8 @@ export async function resolveIdentifiers(client: ConferenceMatrixClient, people: | |||
|
|
|||
| export async function invitePersonToRoom(client: ConferenceMatrixClient, resolvedPerson: ResolvedPersonIdentifier, roomId: string): Promise<void> { | |||
There was a problem hiding this comment.
I wonder if we can slip in a dry-run flag in the config, and just skip this function if so? Worst case, maybe we just override the inviteUser function in ConferenceMatrixClient.
There was a problem hiding this comment.
A dry run flag is a much better approach - I've added one, let me know what you think.
Half-Shot
approved these changes
Jan 16, 2024
Co-authored-by: Will Hunt <[email protected]>
|
Merged #209 into main. |
H-Shay
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a flag to seal off sending live emails/invites, making testing less risky.