Pick out useful commits from last year's hotfixes #219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… more spammy than useful
reivilibre
force-pushed
the
rei/fd2024_a
branch
from
ab8cdbe
to
257dca0
Compare
H-Shay
approved these changes
Feb 1, 2024
| @@ -60,9 +61,12 @@ export async function doAuditoriumResolveAction( | |||
| ? await conference.getInviteTargetsForAuditorium(realAud) | |||
| : await conference.getModeratorsForAuditorium(realAud); | |||
| const resolvedAudPeople = audPeople.map(p => allPossiblePeople.find(b => p.id === b.person.id)); | |||
| if (resolvedAudPeople.some(p => !p)) throw new Error(`Failed to resolve all targets for auditorium ${audId}`); | |||
| if (resolvedAudPeople.some(p => !p)) { | |||
| logMessage(LogLevel.WARN, "people", `Failed to resolve all targets for auditorium ${audId}. Inviting others anyway.`, client); | |||
There was a problem hiding this comment.
not sure what the difference between logMessage and LogService (i.e. LogService.warn) which I see being used a lot but if it works, it works :)
There was a problem hiding this comment.
logMessage sends a message to the room, LogService.xxx is for the program's logs
I think
This was referenced Feb 1, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
supersedes: #180, #181
This is a cherrypick and fixup of any useful-looking fixes from those two PRs.
From memory, most of these were done on my own without any other review, some of them in response to actual problems on the day, but we did manage to run a conference with them so fingers crossed they had some practical testing...
Commit-by-commit review makes the most sense here.