Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unmarshal onto partial membershipContent #428

Merged
merged 1 commit into from
Jan 9, 2024

Conversation

S7evinK
Copy link
Contributor

@S7evinK S7evinK commented Jan 9, 2024

This fixes cases where we e.g. receive valid events, but are unable to unmarshal onto MembershipContent because of an invalid displayname (which we don't care about when authing events):

json: cannot unmarshal bool into Go struct field MemberContent.displayname of type string"

@S7evinK S7evinK requested a review from a team January 9, 2024 08:20
Copy link

codecov bot commented Jan 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (85489e2) 59.13% compared to head (8e7c6de) 59.23%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #428      +/-   ##
==========================================
+ Coverage   59.13%   59.23%   +0.10%     
==========================================
  Files          51       51              
  Lines        7128     7129       +1     
==========================================
+ Hits         4215     4223       +8     
+ Misses       2526     2519       -7     
  Partials      387      387              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@S7evinK S7evinK merged commit b70847e into main Jan 9, 2024
7 checks passed
@S7evinK S7evinK deleted the s7evink/fix-membership-allower branch January 9, 2024 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants