Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for getting authenticated federation media #437

Merged
merged 2 commits into from
Aug 1, 2024

Conversation

S7evinK
Copy link
Contributor

@S7evinK S7evinK commented Jul 27, 2024

No description provided.

Copy link

@HenrikSolver HenrikSolver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To my understanding this looks fine.

@@ -736,3 +738,31 @@ func (ac *federationClient) RoomHierarchy(
}
return
}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think documentation in the same spirit as the other methods would be appropriate.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair, and good to document that the caller of this method is responsible to close the returned response body, if any.

Copy link

@HenrikSolver HenrikSolver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@S7evinK S7evinK merged commit d531860 into main Aug 1, 2024
4 of 5 checks passed
@S7evinK S7evinK deleted the s7evink/authed-media branch August 1, 2024 17:38
@S7evinK
Copy link
Contributor Author

S7evinK commented Aug 1, 2024

Thanks for the review! :)

S7evinK added a commit to matrix-org/dendrite that referenced this pull request Aug 16, 2024
neilalexander pushed a commit to neilalexander/harmony that referenced this pull request Aug 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants