Skip to content

Commit

Permalink
ci: Enable CI for draft PRs (#3815)
Browse files Browse the repository at this point in the history
Our CI used to be quite slow and used up a lot of CI time, so as an
optimization we disabled CI for draft PRs.

This is a bit annoying since people want to open draft PRs to check if
CI passes, but without triggering any review requests.

Since our CI is nowadays a bit more efficient let's see if we can enable
it for draft PRs.
  • Loading branch information
poljar authored Aug 8, 2024
1 parent f3fe06b commit a03893e
Show file tree
Hide file tree
Showing 6 changed files with 3 additions and 14 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/benchmarks.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ jobs:
name: Run Benchmarks
runs-on: ubuntu-latest
environment: matrix-rust-bot
if: github.event_name == 'push' || !github.event.pull_request.draft
if: github.event_name == 'push'

steps:
- name: Checkout the repo
Expand Down
9 changes: 0 additions & 9 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,6 @@ jobs:
test-matrix-sdk-features:
name: 🐧 [m], ${{ matrix.name }}
needs: xtask
if: github.event_name == 'push' || !github.event.pull_request.draft

runs-on: ubuntu-latest
strategy:
Expand Down Expand Up @@ -79,7 +78,6 @@ jobs:
name: 🐧 [m]-examples
needs: xtask
runs-on: ubuntu-latest
if: github.event_name == 'push' || !github.event.pull_request.draft

steps:
- name: Checkout the repo
Expand Down Expand Up @@ -111,7 +109,6 @@ jobs:
name: 🐧 [m]-crypto
needs: xtask
runs-on: ubuntu-latest
if: github.event_name == 'push' || !github.event.pull_request.draft

steps:
- name: Checkout the repo
Expand Down Expand Up @@ -141,7 +138,6 @@ jobs:
test-all-crates:
name: ${{ matrix.name }}
if: github.event_name == 'push' || !github.event.pull_request.draft

runs-on: ${{ matrix.os }}
strategy:
Expand Down Expand Up @@ -194,7 +190,6 @@ jobs:
test-wasm:
name: 🕸️ ${{ matrix.name }}
needs: xtask
if: github.event_name == 'push' || !github.event.pull_request.draft

runs-on: ubuntu-latest

Expand Down Expand Up @@ -270,7 +265,6 @@ jobs:
formatting:
name: Check Formatting
runs-on: ubuntu-latest
if: github.event_name == 'push' || !github.event.pull_request.draft

steps:
- name: Checkout the repo
Expand All @@ -289,7 +283,6 @@ jobs:
typos:
name: Spell Check with Typos
runs-on: ubuntu-latest
if: github.event_name == 'push' || !github.event.pull_request.draft

steps:
- name: Checkout Actions Repository
Expand All @@ -302,7 +295,6 @@ jobs:
name: Run clippy
needs: xtask
runs-on: ubuntu-latest
if: github.event_name == 'push' || !github.event.pull_request.draft

steps:
- name: Checkout the repo
Expand Down Expand Up @@ -337,7 +329,6 @@ jobs:
integration-tests:
name: Integration test
if: github.event_name == 'push' || !github.event.pull_request.draft

runs-on: ubuntu-latest

Expand Down
1 change: 0 additions & 1 deletion .github/workflows/coverage.yml
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@ jobs:
code_coverage:
name: Code Coverage
runs-on: "ubuntu-latest"
if: github.event_name == 'push' || !github.event.pull_request.draft

# run several docker containers with the same networking stack so the hostname 'postgres'
# maps to the postgres container, etc.
Expand Down
1 change: 0 additions & 1 deletion .github/workflows/documentation.yml
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@ jobs:
docs:
name: All crates
runs-on: ubuntu-latest
if: github.event_name == 'push' || !github.event.pull_request.draft

steps:
- name: Checkout repository
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/upload_coverage.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
name: Codecov

on:
# This workflow is triggered after every successfull execution
# This workflow is triggered after every successful execution
# of `coverage` workflow.
workflow_run:
workflows: ["Code Coverage"]
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/xtask.yml
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ jobs:
id: xtask-cache
with:
path: target/debug/xtask
# use the cache key calculated in the step above. Bit of an awkard
# use the cache key calculated in the step above. Bit of an awkward
# syntax
key: |
${{ steps.cachekey.outputs[format('cachekey-{0}', matrix.cachekey-id)] }}
Expand Down

0 comments on commit a03893e

Please sign in to comment.