sdk-base: Add RoomInfoNotableUpdateReasons::MEMBERSHIP

[jmartinesp]

This fixes left rooms not disappearing from the room list.

• Public API changes documented in changelogs (optional)

Signed-off-by:

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.13%. Comparing base (9c809b9) to head (b45f83b).
Report is 53 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #3717      +/-   ##
==========================================
- Coverage   84.13%   84.13%   -0.01%     
==========================================
  Files         263      263              
  Lines       27584    27589       +5     
==========================================
+ Hits        23208    23212       +4     
- Misses       4376     4377       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[jmartinesp]

@Hywan just double checking, do we still want to use the RoomInfoNotableUpdateReasons APIs? If so I can rebase and fix the conflicts.

[Hywan]

Looks almost good! Thanks for working on this!

[Hywan]

Be careful that it will override an existing entry. Instead, I recommend to use the following code:

Suggested change

	room_info_notable_updates.insert(
	room_info.room_id.to_owned(),
	RoomInfoNotableUpdateReasons::MEMBERSHIP,
	);
	room_info_notable_updates
	.entry(room_id.clone()) // get the entry
	.or_default() // if it doesn't exist, create a default one
	.insert(RoomInfoNotableUpdateReasons::MEMBERSHIP); // insert `MEMBERSHIP`

[jmartinesp]

Should be fixed by ea949a4

[Hywan]

@Hywan just double checking, do we still want to use the RoomInfoNotableUpdateReasons APIs? If so I can rebase and fix the conflicts.

Yes! The idea is to restore this API, as mentioned in #3802.

[jmartinesp]

So... does this need any more changes?

[Hywan]

I don't think so.

[jmartinesp]

Then should we approve it so it can be squashed and merged 😅 ?

[Hywan]

LGTM, thanks!