crypto: Don't recalculate SenderData if the sender is known but not verified #3784
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andybalaam
force-pushed
the
andybalaam/use-senderdata-to-save-lookups-on-decrypt
branch
from
be16e70 to
f10d602
Compare
andybalaam
force-pushed
the
andybalaam/dont-recalc-senderdata-if-known
branch
from
ffe50c3 to
dce6948
Compare
Base automatically changed from
andybalaam/use-senderdata-to-save-lookups-on-decrypt
to
main
August 5, 2024 14:46
andybalaam
force-pushed
the
andybalaam/dont-recalc-senderdata-if-known
branch
from
dce6948 to
7e504a6
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3784 +/- ##
=======================================
Coverage 84.08% 84.09%
=======================================
Files 262 262
Lines 27456 27456
=======================================
+ Hits 23087 23089 +2
+ Misses 4369 4367 -2 ☔ View full report in Codecov by Sentry. |
poljar
reviewed
Aug 6, 2024
Yes, if the sender was not verified at the time we received the message, we are OK continuing to believe that. |
poljar
approved these changes
Aug 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After discussion with @richvdh we realised that the policy we agreed earlier for initial creation of SenderData applies here too: if the sender is known, we stick with that and don't recalculate to find out whether they are verified.
Part of #3751
Applies on top of #3782