Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

timeline: use the EncryptionInfo provided by the replacement event when processing edits #3852

Merged
merged 1 commit into from
Aug 21, 2024
Merged

timeline: use the EncryptionInfo provided by the replacement event when processing edits #3852

merged 1 commit into from
Aug 21, 2024

Conversation

stefanceriu
Copy link
Member

  • this prevents issues where spoofing the sender field is enough to spoof and edit and display wrong decorations in the app
  • fixes matrix-org/internal-config/issues/1549

@stefanceriu stefanceriu requested a review from bnjbvr August 19, 2024 09:36
@stefanceriu stefanceriu requested a review from a team as a code owner August 19, 2024 09:36
@codecov Codecov
Copy link

codecov bot commented Aug 19, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 88.88889% with 1 line in your changes missing coverage. Please review.

Project coverage is 84.08%. Comparing base (a27ebaa) to head (16e42b6).
Report is 1 commits behind head on main.

Files Patch % Lines
crates/matrix-sdk-ui/src/timeline/event_handler.rs 87.50% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #3852      +/-   ##
==========================================
- Coverage   84.08%   84.08%   -0.01%     
==========================================
  Files         261      261              
  Lines       27637    27645       +8     
==========================================
+ Hits        23239    23244       +5     
- Misses       4398     4401       +3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stefanceriu stefanceriu removed the request for review from a team August 19, 2024 12:21
bnjbvr
bnjbvr requested changes Aug 19, 2024
View reviewed changes
crates/matrix-sdk-ui/src/timeline/event_handler.rs Outdated Show resolved Hide resolved
crates/matrix-sdk-ui/src/timeline/event_item/mod.rs Outdated Show resolved Hide resolved
crates/matrix-sdk-ui/src/timeline/tests/edit.rs Outdated Show resolved Hide resolved
crates/matrix-sdk-ui/src/timeline/tests/edit.rs Outdated Show resolved Hide resolved
@stefanceriu stefanceriu force-pushed the stefan/1549 branch 2 times, most recently from 31aa4e7 to 30b4302 Compare August 21, 2024 07:31
@stefanceriu
timeline: use the EncryptionInfo provided by the replacement event …
16e42b6 
…when processing edits

- this prevents issues where spoofing the sender field is enough to spoof and edit and display wrong decorations in the app
- fixes matrix-org/internal-config/issues/1549
@bnjbvr bnjbvr self-requested a review August 21, 2024 08:18
bnjbvr
bnjbvr approved these changes Aug 21, 2024
View reviewed changes
Copy link
Member

@bnjbvr bnjbvr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet, thanks!

@bnjbvr bnjbvr merged commit f0d9860 into main Aug 21, 2024
40 checks passed
@bnjbvr bnjbvr deleted the stefan/1549 branch August 21, 2024 08:31
@pixlwave pixlwave mentioned this pull request Aug 22, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bnjbvr bnjbvr bnjbvr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stefanceriu @bnjbvr