Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MatrixRTC: fix different devices from the same user overwriting the room info state event. #3867

Closed
wants to merge 1 commit into from

Conversation

toger5
Copy link
Contributor

@toger5 toger5 commented Aug 20, 2024

With the new event format we have one event per device (not one event per user). Consequently it does not make a lot of sense to store the state events in the room info using the user id as the keys for the Map of state events.

Instead a tuple of userId and deviceId is used.

  • Public API changes documented in changelogs (optional)

Signed-off-by:

Copy link

codecov bot commented Aug 20, 2024

Codecov Report

Attention: Patch coverage is 96.55172% with 1 line in your changes missing coverage. Please review.

Project coverage is 84.11%. Comparing base (711a753) to head (abc617f).
Report is 241 commits behind head on main.

Files with missing lines Patch % Lines
crates/matrix-sdk-base/src/rooms/mod.rs 95.83% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3867      +/-   ##
==========================================
+ Coverage   84.09%   84.11%   +0.02%     
==========================================
  Files         262      262              
  Lines       27646    27656      +10     
==========================================
+ Hits        23249    23263      +14     
+ Misses       4397     4393       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@toger5 toger5 marked this pull request as ready for review August 21, 2024 11:55
@toger5 toger5 requested a review from a team as a code owner August 21, 2024 11:55
@toger5 toger5 requested review from Hywan and removed request for a team August 21, 2024 11:55
@toger5 toger5 marked this pull request as draft August 21, 2024 11:56
@toger5
Copy link
Contributor Author

toger5 commented Sep 12, 2024

superseded by: #3972

@toger5 toger5 closed this Sep 12, 2024
@poljar poljar deleted the toger5/room-info-multi-session-event-fix branch November 5, 2024 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant