Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Use ruma::time instead of instant #3885

Merged
merged 2 commits into from
Aug 23, 2024

Conversation

zecakeh
Copy link
Collaborator

@zecakeh zecakeh commented Aug 23, 2024

This is a reexport of web-time.

  • Public API changes documented in changelogs (optional)

Closes #2937.

@zecakeh zecakeh requested review from a team as code owners August 23, 2024 09:31
@zecakeh zecakeh requested review from jmartinesp and andybalaam and removed request for a team August 23, 2024 09:31
This is a reexport of web-time.

Signed-off-by: Kévin Commaille <[email protected]>
Signed-off-by: Kévin Commaille <[email protected]>
Copy link
Contributor

@jmartinesp jmartinesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes make sense to me, thanks!

Copy link
Contributor

@andybalaam andybalaam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@andybalaam andybalaam enabled auto-merge (rebase) August 23, 2024 09:52
@andybalaam andybalaam merged commit 6e5601d into matrix-org:main Aug 23, 2024
40 checks passed
Copy link

codecov bot commented Aug 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.09%. Comparing base (be13388) to head (fe893c9).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3885   +/-   ##
=======================================
  Coverage   84.08%   84.09%           
=======================================
  Files         266      266           
  Lines       27744    27746    +2     
=======================================
+ Hits        23328    23332    +4     
+ Misses       4416     4414    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zecakeh zecakeh deleted the use-ruma-time branch August 23, 2024 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Switch to another crate instead of instant
3 participants