chore(test): Upgrade ctor #4351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zecakeh
requested review from
Hywan and
andybalaam
and removed request for
a team
poljar
approved these changes
Nov 29, 2024
andybalaam
approved these changes
Nov 29, 2024
|
Ah we need #4350 for CI |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4351 +/- ##
=======================================
Coverage 85.09% 85.09%
=======================================
Files 280 280
Lines 30535 30535
=======================================
+ Hits 25984 25985 +1
+ Misses 4551 4550 -1 ☔ View full report in Codecov by Sentry. |
Fixes the `unexpected_cfgs` warning so it doesn't need to be disabled anymore. Signed-off-by: Kévin Commaille <[email protected]>
zecakeh
force-pushed
the
upgrade-ctor
branch
from
de40490 to
16b0742
Compare
|
Rebased on main to fix the CI. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the
unexpected_cfgswarning so it doesn't need to be disabled anymore.We are also looking at the one triggered by
EventContentin ruma/ruma#1956, if anyone has an opinion.