chore(xtask): Upgrade xshell #4358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gets rid of an unexpected_cfgs warning. Signed-off-by: Kévin Commaille <[email protected]>
zecakeh
commented
Nov 29, 2024
xtask/src/release.rs
Outdated
| @@ -74,7 +74,8 @@ impl ReleaseArgs { | |||
| // | |||
| // More info: https://git-cliff.org/docs/usage/monorepos | |||
| if self.cmd != ReleaseCommand::Changelog { | |||
| let _p = pushd(workspace::root_path()?)?; | |||
| let sh = sh(); | |||
| let _p = sh.push_dir(workspace::root_path()?); | |||
There was a problem hiding this comment.
I am not sure if I understand the initial intent here. Because pushd / Shell::push_dir returns a RAII guard, it stop having an effect as soon as it is out of scope. And it is out of scope right after being created.
There was a problem hiding this comment.
The intention was to not change the directory to the workspace if the Changelog command is used.
A let _p; before the if branch give the guard the correct lifetime. Could you add that please?
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4358 +/- ##
==========================================
+ Coverage 85.09% 85.11% +0.01%
==========================================
Files 280 280
Lines 30535 30535
==========================================
+ Hits 25984 25990 +6
+ Misses 4551 4545 -6 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Kévin Commaille <[email protected]>
poljar
approved these changes
Nov 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gets rid of an
unexpected_cfgswarning. Alternative to #4352.Because most subcommands are functions, this uses a thread-local static shared shell API. If they were methods, we could just use a shared shell API for a given command.