Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove some allow(dead_code) annotations #4472

Merged
merged 9 commits into from
Jan 8, 2025

Conversation

bnjbvr
Copy link
Member

@bnjbvr bnjbvr commented Jan 7, 2025

We have quite a few allow(dead_code) annotations. While it's OK to use in situations where the Cargo-feature combination explodes and makes it hard to reason about when something is actually used or not, in other situations it can be avoided, and show actual, dead code.

@bnjbvr bnjbvr requested review from a team as code owners January 7, 2025 17:29
@bnjbvr bnjbvr requested review from Hywan and richvdh and removed request for a team January 7, 2025 17:29
Copy link

codecov bot commented Jan 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.11%. Comparing base (618e472) to head (da8b46a).
Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4472      +/-   ##
==========================================
+ Coverage   85.07%   85.11%   +0.04%     
==========================================
  Files         283      283              
  Lines       31775    31763      -12     
==========================================
+ Hits        27033    27036       +3     
+ Misses       4742     4727      -15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bnjbvr bnjbvr merged commit aca8c8b into main Jan 8, 2025
39 of 40 checks passed
@bnjbvr bnjbvr deleted the bnjbvr/remove-allow-dead-code branch January 8, 2025 09:37
@Hywan
Copy link
Member

Hywan commented Jan 8, 2025

Thanks for the clean up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants