Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support anvil_ namespace for Rivet #160

Open
MexicanAce opened this issue Oct 5, 2023 · 0 comments
Open

Support anvil_ namespace for Rivet #160

MexicanAce opened this issue Oct 5, 2023 · 0 comments
Labels
feature ➕ Feature item medium 🚩 Indicates moderately difficult item p2 🟡 Indicates moderately high priority item

Comments

@MexicanAce
Copy link
Collaborator

🌟 Feature Request

📝 Description

The tool Rivet from Paradigm is great, but relies on a set of APIs from the anvil_ namespace (via the viem client). For the most part, these endpoints are the exact same as the evm_ (maybe a few specials ones on top of that).

This Issue would require a refactor of storing the implementation of some functions to be stored in a centralized location so it can be re-used accordingly. For example, the following endpoints are doing the same thing:

  • evm_setAccountNonce
  • hardhat_setNonce
  • anvil_setNonce

Here's the full list of endpoints supported by the viem client (e.g. the anvil_ namespace): https://github.com/wagmi-dev/viem/blob/main/src/clients/decorators/test.ts

🤔 Rationale

Supporting Rivet as a first-class tool for debugging would be beneficial for developers of dApps.

📋 Additional Context

There's an option to submit an upstream Pull Request to Rivet that would update their client.mode to be configurable and this would change the namespace of the requests (e.g. new Client({mode: 'evm'}) would call evm_setNonce instead of anvil_setNonce). However, I think we should avoid this option as there are small differences between the hardhat, evm, and rivet namespaces that it's more flexible for us to support all 3.

@MexicanAce MexicanAce added p2 🟡 Indicates moderately high priority item medium 🚩 Indicates moderately difficult item feature ➕ Feature item labels Oct 5, 2023
IAvecilla pushed a commit to lambdaclass/era-test-node that referenced this issue Feb 29, 2024
@vbar vbar mentioned this issue Jul 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature ➕ Feature item medium 🚩 Indicates moderately difficult item p2 🟡 Indicates moderately high priority item
Projects
None yet
Development

No branches or pull requests

1 participant