Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(contracts)!: gateway integration #1934

Merged
merged 738 commits into from
Jan 15, 2025
Merged

feat(contracts)!: gateway integration #1934

merged 738 commits into from
Jan 15, 2025

Conversation

StanislavBreadless
Copy link
Contributor

@StanislavBreadless StanislavBreadless commented May 14, 2024

What ❔

  • v26 contracts
  • zkstack_cli compatible with v26 contracts & scripts
  • final server improvements for v26, ProtocolVersionId::latest() is set to v26
  • prover version is set to v26

Why ❔

Checklist

  • PR title corresponds to the body of PR (we generate changelog entries from PRs).
  • Tests for the changes have been added / updated.
  • Documentation comments have been added / updated.
  • Code has been formatted via zk fmt and zk lint.
  • Spellcheck has been run via zk spellcheck.

@StanislavBreadless StanislavBreadless changed the title Sync layer stable WIP: synclayer May 14, 2024
@StanislavBreadless StanislavBreadless changed the title WIP: synclayer feat(contracts)!: synclayer integration May 16, 2024
@EmilLuta
Copy link
Contributor

Folks, this PR is getting scary each passing day. What's the plan to integrate it?

## What ❔

<!-- What are the changes this PR brings about? -->
<!-- Example: This PR adds a PR template to the repo. -->
<!-- (For bigger PRs adding more context is appreciated) -->

## Why ❔

<!-- Why are these changes done? What goal do they contribute to? What
are the principles behind them? -->
<!-- Example: PR templates ensure PR reviewers, observers, and future
iterators are in context about the evolution of repos. -->

## Checklist

<!-- Check your PR fulfills the following items. -->
<!-- For draft PRs check the boxes as you complete them. -->

- [ ] PR title corresponds to the body of PR (we generate changelog
entries from PRs).
- [ ] Tests for the changes have been added / updated.
- [ ] Documentation comments have been added / updated.
- [ ] Code has been formatted via `zkstack dev fmt` and `zkstack dev
lint`.

---------

Co-authored-by: Stanislav Breadless <[email protected]>
Copy link
Contributor

⚠ Detected differing instruction counts

Benchmark Old count New count
access_memory 4748128 4748374
call_far 319701 319525
decode_shl_sub 4748233 4748479
deploy_simple_contract 15638 15422
event_spam 2581727 2558512
finish_eventful_frames 786173 786039
heap_read_write 4252625 4252844
slot_hash_collision 4749132 4749388
write_and_decode 4749132 4749388

Changes in number of opcodes executed indicate that the gas price of the benchmark has changed, which causes it to run out of gas at a different time.

@perekopskiy perekopskiy changed the title feat(contracts)!: synclayer integration feat(contracts)!: gateway integration Jan 15, 2025
Copy link
Contributor

@yorik yorik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for workflows

@perekopskiy perekopskiy added this pull request to the merge queue Jan 15, 2025
@perekopskiy perekopskiy removed this pull request from the merge queue due to a manual request Jan 15, 2025
@perekopskiy perekopskiy added this pull request to the merge queue Jan 15, 2025
Merged via the queue into main with commit f06cb79 Jan 15, 2025
48 checks passed
@perekopskiy perekopskiy deleted the sync-layer-stable branch January 15, 2025 10:30
randomsuperher pushed a commit that referenced this pull request Jan 17, 2025
🤖 I have created a release *beep* *boop*
---


##
[26.0.0](core-v25.4.0...core-v26.0.0)
(2025-01-17)


### ⚠ BREAKING CHANGES

* **contracts:** gateway integration
([#1934](#1934))

### Features

* Adapt server for new EVM bytecode hash encoding
([#3396](#3396))
([5a1e6d2](5a1e6d2))
* Add logging & metrics for mempool
([#3447](#3447))
([64d861d](64d861d))
* **api_server:** report gas price based on open batch
([#2868](#2868))
([f30aca0](f30aca0))
* **contracts:** gateway integration
([#1934](#1934))
([f06cb79](f06cb79))
* da_dispatcher refactoring
([#3409](#3409))
([591cd86](591cd86))
* **en:** make documentation more chain agnostic
([#3376](#3376))
([361243f](361243f))
* **eth-sender:** make base fee grow at least as fast as priority fee
([#3386](#3386))
([78af2bf](78af2bf))
* **eth-watch:** Change protocol upgrade schema
([#3435](#3435))
([2c778fd](2c778fd))
* Features for an easier upgrade
([#3422](#3422))
([3037ee6](3037ee6))
* FFLONK support for compressor
([#3359](#3359))
([1a297be](1a297be))
* pubdata type changes from sync-layer-stable
([#3425](#3425))
([f09087b](f09087b))


### Bug Fixes

* **api:** Propagate fallback errors in traces
([#3469](#3469))
([84e3e31](84e3e31))
* **en:** make EN use main node's fee input
([#3489](#3489))
([cbf2c31](cbf2c31))
* eth aggregator restriction
([#3490](#3490))
([6cc9b9e](6cc9b9e))


### Performance Improvements

* **eth-sender:** optimize sql query
([#3437](#3437))
([0731f60](0731f60))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

---------

Co-authored-by: Tomasz Grześkiewicz <[email protected]>
Co-authored-by: zksync-era-bot <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants