Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(vm): Implement call tracing for fast VM #2905

Open
wants to merge 21 commits into
base: main
Choose a base branch
from
Open

feat(vm): Implement call tracing for fast VM #2905

wants to merge 21 commits into from

Conversation

joonazan
Copy link
Contributor

@joonazan joonazan commented Sep 17, 2024 •
edited by slowli
Loading

What ❔

  • Implements call tracing for the fast VM.
  • Enables call tracing for the batch VM executor (i.e., one used in the state keeper) if it is requested. Compares produced traces in the shadow VM mode.

Why ❔

Call tracing is the last large missing part of the fast VM.

@joonazan joonazan force-pushed the jms-call-tracer branch 4 times, most recently from 1cc9ec9 to 6a0c824 Compare September 24, 2024 17:20
@joonazan joonazan changed the base branch from main to jms-pla-908-account-validation-properly-handle-when-out-of-gas November 15, 2024 13:42
@joonazan joonazan changed the base branch from jms-pla-908-account-validation-properly-handle-when-out-of-gas to main November 15, 2024 14:54
@joonazan joonazan marked this pull request as ready for review November 15, 2024 14:55
@joonazan
Copy link
Contributor Author

This does not turn enable call tracing in API because of the details of how that happens depend on #2863 so it is better to wait until both PRs are in.

@slowli slowli requested a review from perekopskiy January 14, 2025 13:52
@slowli slowli changed the title feat: vm2 call tracer feat(vm): Implement call tracing for fast VM Jan 14, 2025
popzxc
popzxc approved these changes Jan 17, 2025
View reviewed changes
Copy link
Member

@popzxc popzxc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is certainly not the domain I'm comfortable with, but I've looked through the diff and it doesn't look suspicious. Not very helpful, but LGTM 😅

@slowli slowli added this pull request to the merge queue Jan 17, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@perekopskiy perekopskiy perekopskiy approved these changes

@popzxc popzxc popzxc approved these changes

@slowli slowli Awaiting requested review from slowli

@StanislavBreadless StanislavBreadless Awaiting requested review from StanislavBreadless

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@joonazan @popzxc @perekopskiy @slowli