refactor(zk_toolbox): Minimize dependency on zksync_config
#3436
Conversation
There was a problem hiding this comment.
The remaining zksync_config uses in the config crate are related to GatewayConfig and GatewayChainConfig. Not sure what to do with these mentions because both configs are created from scratch in migrate_from_gateway / migrate_to_gateway modules (rather than being created from a template); so using the same approach as for GeneralConfig etc. is somewhat problematic. OTOH, these configs do not adhere to Protobuf serialization format anyway 🤷 I guess they could be dealt with in a separate PR (still before the config system integration).
| update_from_chain_config(&mut genesis_config, &chain_config)?; | ||
| // FIXME: config isn't saved; why? |
| .http_url, | ||
| )?; | ||
| let general_config = gateway_chain_config.get_general_config().await?; | ||
| let l2_rpc_url = general_config.get::<String>("api.web3_json_rpc.http_url")?; |
There was a problem hiding this comment.
Uses of http_url / ws_url are somewhat problematic because these config params are never actually used by the node. Other similarly unused params are postgres.test.{server_url, prover_url}. I've left them as-is so far, but IMO they should be removed.
slowli
requested review from
popzxc,
StanislavBreadless,
perekopskiy and
Artemka374
There was a problem hiding this comment.
Yes! Nice!
I'd still recommend getting a review from @sanekmelnikov before merging.
slowli
requested review from
alexandrst88,
artmakh,
hatemosphere,
onyxet,
otani88 and
iluwaa
What ❔
Largely removes
zkstackdependency onzksync_config.Why ❔
This dependency significantly complicates new config system integration. While the alternative is less typesafe, it can be made more typesafe in the future once the config system integration is complete (a node binary can then be used to validate the changed config values).
Checklist
zkstack dev fmtandzkstack dev lint.