Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes /welcomebot preview teamname command not working. #74

Merged
merged 4 commits into from
Aug 19, 2021
Merged

Fixes /welcomebot preview teamname command not working. #74

merged 4 commits into from
Aug 19, 2021

Conversation

maisnamrajusingh
Copy link
Contributor

@maisnamrajusingh maisnamrajusingh commented Jun 10, 2021 •
edited by hanzei
Loading

Summary

  • Fixes issue of /welcomebot preview teamname command not working.

Ticket Link

Fixes #71

@mattermod
Copy link
Contributor

Hello @maisnamrajusingh,

Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.

hanzei
hanzei requested changes Jun 10, 2021
View reviewed changes
Copy link
Contributor

@hanzei hanzei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The behavior change is fine, but it needs to be carried through whole code and the docs.

server/command.go Outdated Show resolved Hide resolved
@hanzei hanzei added 2: Dev Review Requires review by a core committer 3: QA Review Requires review by a QA tester labels Jun 10, 2021
@hanzei hanzei mentioned this pull request Jun 17, 2021
Closed
@maisnamrajusingh maisnamrajusingh changed the title [GH-71] Fixes /welcomebot preview teamname command not working. Jun 23, 2021
@mattermod
Copy link
Contributor

This PR has been automatically labelled "stale" because it hasn't had recent activity.
A core team member will check in on the status of the PR to help with questions.
Thank you for your contribution!

/cc @jasonblais @jfrerich @emilyacook

@maisnamrajusingh
Copy link
Contributor Author

@hanzei I over thought what the problem was. The issue actually was that the user had Cudy as the team name and in the config whereas the GetTeamByName was expecting the values in lowercase. I reverted back my previous changes and added a string conversion to lower case when we fetch the team by its name

@maisnamrajusingh maisnamrajusingh requested a review from hanzei July 28, 2021 16:42
@maisnamrajusingh
Copy link
Contributor Author

@hanzei can you take a look at this and see if it needs anything else from my side ?

hanzei
hanzei approved these changes Aug 12, 2021
View reviewed changes
Copy link
Contributor

@hanzei hanzei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

server/welcomebot.go
@@ -57,7 +57,7 @@ func (p *Plugin) getSiteURL() string {
return *config.ServiceSettings.SiteURL
}

func (p *Plugin) newSampleMessageTemplate(teamName, userID string) (*MessageTemplate, error) {
func (p *Plugin) newSampleMessageTemplate(teamName string, userID string) (*MessageTemplate, error) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit pick: Unrelated change

@hanzei
Copy link
Contributor

hanzei commented Aug 12, 2021

@jfrerich Please take a look

@hanzei hanzei added this to the v1.3.0 milestone Aug 12, 2021
jfrerich
jfrerich approved these changes Aug 12, 2021
View reviewed changes
Copy link
Contributor

@jfrerich jfrerich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@hanzei hanzei added 4: Reviews Complete All reviewers have approved the pull request and removed 2: Dev Review Requires review by a core committer 3: QA Review Requires review by a QA tester labels Aug 19, 2021
@hanzei
Copy link
Contributor

hanzei commented Aug 19, 2021

Deferring QA to release testing

@hanzei hanzei merged commit 77bd89a into mattermost-community:master Aug 19, 2021
@mickmister mickmister mentioned this pull request Apr 28, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasonblais jasonblais jasonblais left review comments

@hanzei hanzei hanzei approved these changes

@jfrerich jfrerich jfrerich approved these changes

Assignees
No one assigned
Labels
4: Reviews Complete All reviewers have approved the pull request
Projects
None yet
Milestone
v1.3.0
Development

Successfully merging this pull request may close these issues.

"preview" command not working
5 participants
@maisnamrajusingh @mattermod @hanzei @jfrerich @jasonblais