Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MM-45894] Allow signaling through data channel #39

Merged
merged 3 commits into from
Oct 9, 2024
Merged

Conversation

streamer45
Copy link
Contributor

@streamer45 streamer45 commented Sep 24, 2024

Summary

Client-side changes are minor.

  • We check for the flag to be on to decide whether to send offers through the DC.
  • We naturally exclude the very first exchange by checking whether the channel is already connected.
  • We add a handler for SDPs coming on the DC.

Related PRs

mattermost/mattermost-plugin-calls#865
mattermost/rtcd#156

Ticket Link

https://mattermost.atlassian.net/browse/MM-45894

cpoile
cpoile previously approved these changes Sep 30, 2024
@cpoile cpoile added 3: Reviews Complete All reviewers have approved the pull request and removed 2: Dev Review Requires review by a core committer labels Sep 30, 2024
* Implement data channel message type

* Better logging

* Update

* Ignore jest setup files

* [MM-60561] RTC client metrics (#41)

* Client metrics

* Improve loss detection in case of senders of loss
@streamer45
Copy link
Contributor Author

stale review 😒

@streamer45 streamer45 requested a review from cpoile October 9, 2024 21:32
@streamer45 streamer45 merged commit 8d2b13b into master Oct 9, 2024
4 checks passed
@streamer45 streamer45 deleted the MM-45894 branch October 9, 2024 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3: Reviews Complete All reviewers have approved the pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants