Decouple shared packages #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpoile
approved these changes
Jun 23, 2023
cpoile
added
3: Reviews Complete
streamer45
added a commit
that referenced
this pull request
Jul 28, 2023
* [MM-52322] Support multiple APIs implementations (#23) * JobService interface * Bump build deps * [MM-52323] Refactor docker implementation (#24) * Refactor docker job service * Add tests * Build and release docker image (#25) * [MM-52346] Kubernetes implementation (#26) * Setup k8s client * Implement k8s API * Remove StopJob * Implement Init() API call * Setup k8s CI * Update sample config * Add local k8s development doc * Use human friendly prefix for job names * Add support for passing custom tolerations * Expose version info (#28) * Implement unauthorized client error (#27) * Update k8s client deps to latest * Decouple public packages (#32) * Enforce MaxConcurrentJobs limit (#33) * Bump calls-recorder * Update dev docs * Explicitly set image pulling policy * Support fetching dev builds from calls-recorder-daily registry
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
PR extracts shared constructs (i.e.
Client,Job,VersionInfo) into decoupled packages under a commonpublictop level directory/package. This is necessary to avoid the plugin side (or any other importer) from indirectly importing all sorts of unnecessary dependencies (e.g. docker, kubernetes).