Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MM-57408 - Update transcriber for LiveCaptionsLanguage config field #54

Closed
wants to merge 1 commit into from

Conversation

cpoile
Copy link
Member

@cpoile cpoile commented Mar 22, 2024

Summary

  • Add LiveCaptionsLanguage setting

Ticket Link

@cpoile cpoile added the 2: Dev Review Requires review by a core committer label Mar 22, 2024
@cpoile cpoile requested a review from streamer45 March 22, 2024 22:27
@streamer45 streamer45 added this to the v0.7.1 milestone Mar 22, 2024
@@ -10,7 +10,7 @@ require (
github.com/gorilla/mux v1.8.1
github.com/kelseyhightower/envconfig v1.4.0
github.com/mattermost/calls-recorder v0.6.0
github.com/mattermost/calls-transcriber v0.1.9-0.20240207195159-3f96d0ad8031
github.com/mattermost/calls-transcriber v0.2.2-dev.0.20240322211857-e206786e4829
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be updated.

@streamer45 streamer45 added 3: Reviews Complete All reviewers have approved the pull request Do Not Merge/Awaiting PR Awaiting another pull request before merging (e.g. server changes) and removed 2: Dev Review Requires review by a core committer labels Mar 22, 2024
@streamer45
Copy link
Contributor

@cpoile I think we can safely close this one since it will be unnecessary after #55 gets in.

@cpoile
Copy link
Member Author

cpoile commented Mar 27, 2024

Unneeeded now with #55

@cpoile cpoile closed this Mar 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3: Reviews Complete All reviewers have approved the pull request Do Not Merge/Awaiting PR Awaiting another pull request before merging (e.g. server changes)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants