Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MM-58014] Performance benchmarking for live captions #57

Merged
merged 5 commits into from
May 27, 2024
Merged

[MM-58014] Performance benchmarking for live captions #57

merged 5 commits into from
May 27, 2024

Conversation

cpoile
Copy link
Member

@cpoile cpoile commented Apr 29, 2024

Summary

  • Performance benchmarking for live captions

Ticket Link

@cpoile cpoile added the 2: Dev Review Requires review by a core committer label Apr 29, 2024
@cpoile cpoile requested a review from streamer45 April 29, 2024 21:12
streamer45
streamer45 approved these changes Apr 30, 2024
View reviewed changes
Copy link
Contributor

@streamer45 streamer45 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks for spending time on this 💯

Slightly unrelated: if we don't have one, could we create a ticket to update our official Grafana dashboard with all the new metrics you added as part of this work?

docs/performance.md Outdated Show resolved Hide resolved
@streamer45 streamer45 added 3: Reviews Complete All reviewers have approved the pull request and removed 2: Dev Review Requires review by a core committer labels Apr 30, 2024
@cpoile cpoile added the Do Not Merge/Awaiting PR Awaiting another pull request before merging (e.g. server changes) label May 24, 2024
@cpoile cpoile removed Do Not Merge/Awaiting PR Awaiting another pull request before merging (e.g. server changes) labels May 27, 2024
@cpoile cpoile changed the title [mm-58014] Performance benchmarking for live captions [MM-58014] Performance benchmarking for live captions May 27, 2024
@cpoile cpoile merged commit a765ab8 into master May 27, 2024
3 checks passed
@cpoile cpoile deleted the MM-58014-live-captions-benchmarking branch May 27, 2024 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@streamer45 streamer45 streamer45 approved these changes

Assignees
No one assigned
Labels
3: Reviews Complete All reviewers have approved the pull request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cpoile @streamer45