Add tests for tables from cmark-gfm

I also had to update the output of the HTML renderer to match changes made in github/cmark-gfm@1470c30, and our existing table tests needed to be updated for that as well.
mattermost · Oct 25, 2024 · 2148a1a · 2148a1a
1 parent 6d239b1
commit 2148a1a
Show file tree

Hide file tree

Showing 6 changed files with 705 additions and 63 deletions.
diff --git a/dist/commonmark.js b/dist/commonmark.js
@@ -15809,12 +15809,15 @@
             this.cr();
         } else {
             this.tag("/tr");
+            this.cr();
 
             if (node === node.parent.firstChild) {
                 this.cr(); // we're not consistent about how these tags are laid out because this is what GitHub does
                 this.tag("/thead");
+                this.cr();
             } else if (node === node.parent.lastChild) {
                 this.tag("/tbody");
+                this.cr();
             }
         }
     }
@@ -15949,7 +15952,7 @@
 
         this.indentLevel = 0;
         this.indent = "  ";
-
+        
         this.esc = options.esc || escapeXml;
         // escape html with a custom function
         // else use escapeXml
@@ -16048,7 +16051,7 @@
                         attrs.push(["on_exit", node.onExit]);
                         break;
                 }
-                {
+                if (options.sourcepos) {
                     var pos = node.sourcepos;
                     if (pos) {
                         attrs.push([

diff --git a/dist/commonmark.min.js b/dist/commonmark.min.js
diff --git a/lib/render/html.js b/lib/render/html.js
@@ -288,12 +288,15 @@ function table_row(node, entering) {
         this.cr();
     } else {
         this.tag("/tr");
+        this.cr();
 
         if (node === node.parent.firstChild) {
             this.cr(); // we're not consistent about how these tags are laid out because this is what GitHub does
             this.tag("/thead");
+            this.cr();
         } else if (node === node.parent.lastChild) {
             this.tag("/tbody");
+            this.cr();
         }
     }
 }