Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(e2e): add a job to run e2e on linux os #2796

Merged
merged 46 commits into from
Oct 24, 2023
Merged

feat(e2e): add a job to run e2e on linux os #2796

merged 46 commits into from
Oct 24, 2023

Conversation

yasserfaraazkhan
Copy link
Contributor

@yasserfaraazkhan yasserfaraazkhan commented Jul 21, 2023 •
edited
Loading

  • Add Run Desktop E2E test label to trigger e2e jobs on Mac OS, linux and windows
  • Doc on how to run
NONE

@yasserfaraazkhan
Copy link
Contributor Author

yasserfaraazkhan commented Jul 24, 2023 •
edited
Loading

  • using matrix to try running same job for multiple OS, but in case the steps get complicated, will keep separate job for each os.
  • Cmd to run npm run test:e2e || true, do not want to block PRs due to flaky tests, working on fixing.
  • Working on adding reporting.

thank you @mario the smokes tests in mono repo served as a reference.

@mvitale1989 mvitale1989 self-requested a review July 24, 2023 10:52
devinbinnie
devinbinnie approved these changes Jul 24, 2023
View reviewed changes
Copy link
Member

@devinbinnie devinbinnie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving to unblock, thanks again @yasserfaraazkhan for taking this on :)

@yasserfaraazkhan
Copy link
Contributor Author

https://community.mattermost.com/core/pl/me9rbky3mbd85qwmqhj1nkebbr

example report

@yasserfaraazkhan yasserfaraazkhan added the Run Desktop E2E Tests This label will trigger the workflow that runs e2e automation tests label Sep 20, 2023
@github-actions github-actions bot removed the Run Desktop E2E Tests This label will trigger the workflow that runs e2e automation tests label Sep 20, 2023
@yasserfaraazkhan yasserfaraazkhan added the Run Desktop E2E Tests This label will trigger the workflow that runs e2e automation tests label Sep 22, 2023
@github-actions github-actions bot removed the Run Desktop E2E Tests This label will trigger the workflow that runs e2e automation tests label Sep 22, 2023
@yasserfaraazkhan yasserfaraazkhan added the Run Desktop E2E Tests This label will trigger the workflow that runs e2e automation tests label Sep 22, 2023
@github-actions github-actions bot removed the Run Desktop E2E Tests This label will trigger the workflow that runs e2e automation tests label Sep 22, 2023
@yasserfaraazkhan
Copy link
Contributor Author

/update-branch

@yasserfaraazkhan yasserfaraazkhan added Run Desktop E2E Tests This label will trigger the workflow that runs e2e automation tests and removed Run Desktop E2E Tests This label will trigger the workflow that runs e2e automation tests labels Oct 2, 2023
toninis
toninis reviewed Oct 4, 2023
View reviewed changes
.github/workflows/e2e-functional.yml

jobs:
e2e-linux:
if: ${{ github.event.label.name == 'Run Desktop E2E Tests' }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@yasserfaraazkhan yasserfaraazkhan added the Run Desktop E2E Tests This label will trigger the workflow that runs e2e automation tests label Oct 5, 2023
@github-actions github-actions bot removed the Run Desktop E2E Tests This label will trigger the workflow that runs e2e automation tests label Oct 5, 2023
@yasserfaraazkhan yasserfaraazkhan added the Run Desktop E2E Tests This label will trigger the workflow that runs e2e automation tests label Oct 20, 2023
@github-actions github-actions bot removed the Run Desktop E2E Tests This label will trigger the workflow that runs e2e automation tests label Oct 20, 2023
@yasserfaraazkhan yasserfaraazkhan added the Run Desktop E2E Tests This label will trigger the workflow that runs e2e automation tests label Oct 20, 2023
@github-actions github-actions bot removed the Run Desktop E2E Tests This label will trigger the workflow that runs e2e automation tests label Oct 20, 2023
@yasserfaraazkhan
Copy link
Contributor Author

/update-branch

@yasserfaraazkhan yasserfaraazkhan requested review from hmhealey and saturninoabril and removed request for mvitale1989 October 23, 2023 17:58
@yasserfaraazkhan yasserfaraazkhan merged commit 932eff2 into master Oct 24, 2023
11 checks passed
@yasserfaraazkhan yasserfaraazkhan deleted the test_ci branch October 24, 2023 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@toninis toninis toninis left review comments

@devinbinnie devinbinnie devinbinnie approved these changes

@hmhealey hmhealey hmhealey approved these changes

@saturninoabril saturninoabril Awaiting requested review from saturninoabril

Assignees
No one assigned
Labels
release-note-none
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@yasserfaraazkhan @hmhealey @saturninoabril @toninis @devinbinnie @mm-cloud-bot @mattermost-build