Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add x-scheme-handler to the desktop file script #2917

Merged
merged 1 commit into from
Nov 28, 2023

Conversation

wiebel
Copy link
Contributor

@wiebel wiebel commented Nov 24, 2023

Summary

Small insertion to the Mattermost.desktop file PR as requested
here

Ticket Link

Fixes part of #2906

Release Note

NONE

@mm-cloud-bot
Copy link

@wiebel: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

I understand the commands that are listed here

@mattermost-build
Copy link
Contributor

Hello @wiebel,

Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.

Per the Mattermost Contribution Guide, we need to add you to the list of approved contributors for the Mattermost project.

Please help complete the Mattermost contribution license agreement?
Once you have signed the CLA, please comment with /check-cla and confirm that the CLA check is green.

This is a standard procedure for many open source projects.

Please let us know if you have any questions.

We are very happy to have you join our growing community! If you're not yet a member, please consider joining our Contributors community channel to meet other contributors and discuss new opportunities with the core team.

@devinbinnie
Copy link
Member

@wiebel Change looks good, thanks for doing that :)
Can you make sure to sign the CLA as per above? Then I can finish reviewing.

@wiebel
Copy link
Contributor Author

wiebel commented Nov 24, 2023

/check-cla

Copy link
Member

@devinbinnie devinbinnie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @wiebel!

@devinbinnie devinbinnie added 4: Reviews Complete All reviewers have approved the pull request and removed 2: Dev Review Requires review by a core committer labels Nov 28, 2023
@devinbinnie devinbinnie merged commit 8171f0f into mattermost:master Nov 28, 2023
26 checks passed
@amyblais amyblais added this to the v5.7.0 milestone Nov 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4: Reviews Complete All reviewers have approved the pull request Contributor release-note-none
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants