[MM-61725] Remove unnecessary macOS entitlements #3207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devinbinnie
requested review from
a team and
sbishel
and removed request for
a team
devinbinnie
added
2: Dev Review
|
@yasserfaraazkhan Can you smoke test this quickly? Nothing should be broken but it's worth having a quick check. |
enzowritescode
approved these changes
Nov 13, 2024
larkox
approved these changes
Nov 14, 2024
yasserfaraazkhan
added
the
Run Desktop E2E Tests
|
Here are the test results below: Test Summary for Linux on commit 738c585The following known failed tests have been fixed on Linux: Test Summary for macOS on commit 738c585The following known failed tests have been fixed on macOS: |
github-actions
bot
removed
the
Run Desktop E2E Tests
yasserfaraazkhan
approved these changes
Nov 14, 2024
devinbinnie
removed
3: QA Review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
These entitlements are not necessary for the app to function under macOS anymore, as they are from older Electron versions. This PR removes these entitlements.
Ticket Link
https://mattermost.atlassian.net/browse/MM-61725