-
Notifications
You must be signed in to change notification settings - Fork 582
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GH-7066 (code background redundancy) #7446
base: master
Are you sure you want to change the base?
GH-7066 (code background redundancy) #7446
Conversation
Hello @chessmadridista, Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here. |
Newest code from chessmadridista has been published to preview environment for Git SHA 42d0a49 |
@chessmadridista - I very much appreciate your patience on a review of this PR. "The redundant background was removed by removing an extra indentation in the code blocks. The redundant background can be removed in other files following the same approach." The extra indentation in the code blocks is intentional and should not be modified. Adjusting indentation isn't a viable way to address the redundant background display issue. By default, the Sphinx theme (Furo) being used adds a background colour to code blocks. Additional CSS is being applied on top resulting in the redundant background issue. |
@cwarnermm Thank you for the feedback! I'll look into it and will make the necessary changes. |
This PR has been automatically labelled "stale" because it hasn't had recent activity. |
@chessmadridista - Are you actively working on this issue? |
Not at the moment. I plan to take it up after 2-3 weeks if nobody else picks this up. Apologies for not intimating you about the same. |
@chessmadridista - Given that this issue is assigned to you, others from the community won't pick it up. Do you plan to continue working from this PR, or do you plan to create a new docs PR? |
Summary
Code redundancy issues have been resolved for prepare-mattermost-database.rst. Issues for other files will be submitted in separate PRs. Once all the files have been modified, the main issue will be marked as completed and closed.
The redundant background was removed by removing an extra indentation in the code blocks. The redundant background can be removed in other files following the same approach.
Ticket Link
#7066
Note: There are multiple files that need to be taken care of in this issue. Please do not mark this issue as closed.