Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix link within heading font #7521

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Fix link within heading font #7521

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
605e3df
Fix link within heading font
rishy-2021 Aug 25, 2023
26397b0
change font of heading link
rishy-2021 Aug 26, 2023
754e98e
memoize textStyles
rishy-2021 Aug 27, 2023
150c0ef
fixes indentation in textStyles
rishy-2021 Aug 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/utils/markdown/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ export const getMarkdownTextStyles = makeStyleSheetFromTheme((theme: Theme) => {
},
link: {
color: theme.linkColor,
fontFamily: 'OpenSans',
fontFamily: 'Metropolis',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is not the proper fix, as a link in normal paragraph will now use Metropolis instead of openSans

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, i misunderstood the code , now only the heading link font is Metropolis

},
heading1: {
...typography('Heading', 700),
Expand Down