Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MM-56555] Patch commonmark to resolve unmentioned username #7761

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

cyberjam
Copy link
Contributor

Summary

When a username that starts with number or period, underscore, dash is mentioned, the fullname doesn't appear. Only @username is displayed.

Ticket Link

Fixes #7755
JIRA: https://mattermost.atlassian.net/browse/MM-56555

Checklist

  • Added or updated unit tests (required for all new features)
  • Has UI changes
  • Includes text changes and localization file updates
  • Have tested against the 5 core themes to ensure consistency between them.

Device Information

This PR was tested on:

  • Device Name: iPhone 11
  • OS Version: iOS 17.0

Screenshots

Before After
image image

Release Note

NONE

ref : commonmark repo PR

@mattermost-build
Copy link
Contributor

Hello @cyberjam,

Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.

@mattermost-build
Copy link
Contributor

This PR has been automatically labelled "stale" because it hasn't had recent activity.
A core team member will check in on the status of the PR to help with questions.
Thank you for your contribution!

@DAMHONGDUC
Copy link

DAMHONGDUC commented Feb 27, 2024

thanks in advance

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When a username that starts with a number is mentioned, fullname isn't displayed.
4 participants