Hide deactivated users in iOS #8093
Conversation
|
Hello @Juliet879, Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here. |
| if (deactivated) { | ||
| return null; | ||
| } |
There was a problem hiding this comment.
Wouldn't this cause all users deactivated to no longer be displayed? Could you help me clarify that it will not affect other places vs Create Direct Message screen?
Also, take a look at this chunk of code:
if (restrictDirectMessage) {
results = await searchProfiles(serverUrl, lowerCasedTerm, {team_id: currentTeamId, allow_inactive: true});
} else {
results = await searchProfiles(serverUrl, lowerCasedTerm, {allow_inactive: true});
}
@larkox you've made some changes on the chunk of code above, would it be the right way to only show active users?
There was a problem hiding this comment.
You are right, @rahimrahman . Removing the allow_inactive should return us the list of users without deactivated users. That seems to be the right way to do this in this case.
0/5 on whether this will create any problem, like when trying to access old dms with deactivated users, but maybe we can access that in a different way.
There was a problem hiding this comment.
@rahimrahman @larkox thank you for the feedback will adjust this accordingly
There was a problem hiding this comment.
Thank you all folks for your persistence and collaboration to make it happen, - so much looking forward to the fix here from 8074
|
This PR has been automatically labelled "stale" because it hasn't had recent activity. |
|
@Juliet879 do you think you can revitalize this PR and merge your changes please... thank you! |
Summary
Do now show deactivated users in iOS Mobile
Ticket Link
#8074
Device Information
This PR was tested on: iPhone 15 Pro
Screenshots
Release Note