Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MM-60425 Making clickable images work inside Markdown #8215

Merged

Conversation

panoramix360
Copy link
Contributor

@panoramix360 panoramix360 commented Sep 11, 2024

Summary

The following ticket reported that images that were wrapped into a link inside Markdown were not triggering the link itself, but just opened the image.

Previous behavior:

Screen.Recording.2024-09-11.at.11.07.46.mov

I changed the behavior, now if an image is inside a link in Markdown, the user will be able to navigate to the link:

Screen.Recording.2024-09-11.at.11.09.06.mov

Ticket Link

https://mattermost.atlassian.net/browse/MM-60425

#8208

Checklist

  • Added or updated unit tests (required for all new features)
  • Has UI changes
  • Includes text changes and localization file updates
  • Have tested against the 5 core themes to ensure consistency between them.
  • Have run E2E tests by adding label E2E iOS tests for PR.

Device Information

This PR was tested on:

  • iOS Simulator 17.2
  • Android Simulator API 33

Screenshots

It doesn't have any UI changes

Release Note

Images inside Links within Markdown are now clickable for link navigation.

@mm-cloud-bot mm-cloud-bot added kind/bug Categorizes issue or PR as related to a bug. release-note labels Sep 11, 2024
@mattermost-build
Copy link
Contributor

Hello @panoramix360,

Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.

@amyblais amyblais added 2: Dev Review Requires review by a core commiter 3: QA Review Requires review by a QA tester labels Sep 11, 2024
Copy link
Contributor

@rahimrahman rahimrahman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@panoramix360 thank you for this fix. Looks great. I do have 1-2 concerns that maybe we can figure out how to address?

app/components/markdown/markdown.tsx Outdated Show resolved Hide resolved
app/components/markdown/markdown.tsx Outdated Show resolved Hide resolved
app/components/markdown/markdown.tsx Outdated Show resolved Hide resolved
@hmhealey hmhealey changed the title Making clickable images work inside Markdown MM-60425 Making clickable images work inside Markdown Sep 16, 2024
@panoramix360
Copy link
Contributor Author

Thanks for the feedback!!

I'll work on the changes this week!

@panoramix360
Copy link
Contributor Author

Thanks for all the feedback :) That was great! Code is much better now.

Can you review it again?

Copy link
Contributor

@rahimrahman rahimrahman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@panoramix360 way better! I've learned something new as well from @hmhealey.

Copy link
Member

@hmhealey hmhealey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making that change. This looks good to me now!

@hmhealey hmhealey removed the 2: Dev Review Requires review by a core commiter label Sep 17, 2024
@mattermost-build
Copy link
Contributor

This PR has been automatically labelled "stale" because it hasn't had recent activity.
A core team member will check in on the status of the PR to help with questions.
Thank you for your contribution!

@yasserfaraazkhan yasserfaraazkhan added 4: Reviews Complete All reviewers have approved the pull request and removed Lifecycle/1:stale 3: QA Review Requires review by a QA tester labels Oct 7, 2024
@hmhealey hmhealey merged commit 603ea79 into mattermost:main Oct 7, 2024
20 checks passed
@amyblais amyblais added this to the v2.22.0 milestone Oct 8, 2024
@panoramix360 panoramix360 deleted the fix/clickable-images-inside-markdown branch October 8, 2024 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4: Reviews Complete All reviewers have approved the pull request Contributor kind/bug Categorizes issue or PR as related to a bug. release-note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants