-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MM-60425 Making clickable images work inside Markdown #8215
MM-60425 Making clickable images work inside Markdown #8215
Conversation
Hello @panoramix360, Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@panoramix360 thank you for this fix. Looks great. I do have 1-2 concerns that maybe we can figure out how to address?
Thanks for the feedback!! I'll work on the changes this week! |
Thanks for all the feedback :) That was great! Code is much better now. Can you review it again? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@panoramix360 way better! I've learned something new as well from @hmhealey.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for making that change. This looks good to me now!
This PR has been automatically labelled "stale" because it hasn't had recent activity. |
Summary
The following ticket reported that images that were wrapped into a link inside Markdown were not triggering the link itself, but just opened the image.
Previous behavior:
Screen.Recording.2024-09-11.at.11.07.46.mov
I changed the behavior, now if an image is inside a link in Markdown, the user will be able to navigate to the link:
Screen.Recording.2024-09-11.at.11.09.06.mov
Ticket Link
https://mattermost.atlassian.net/browse/MM-60425
#8208
Checklist
E2E iOS tests for PR
.Device Information
This PR was tested on:
Screenshots
It doesn't have any UI changes
Release Note