Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Thai search keywords not properly hi-lighted in the search results. #8347

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

callmeott
Copy link

Previously, Thai search keywords will not be hi-lighted in the search results.

This fix added Thai unicode range into the cjkPattern variable so that Thai search keywords are properly hi-lighted.

sukoom pornsuksiri and others added 3 commits November 14, 2024 11:45
@mm-cloud-bot
Copy link

@callmeott: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

I understand the commands that are listed here

@mattermost-build
Copy link
Contributor

Hello @callmeott,

Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.

@enahum enahum added 2: Dev Review Requires review by a core commiter 3: QA Review Requires review by a QA tester labels Nov 14, 2024
Copy link
Contributor

@larkox larkox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a minor thing and a proposal. Great work!

app/utils/markdown/index.ts Outdated Show resolved Hide resolved
app/utils/markdown/index.ts Show resolved Hide resolved
updated the comment to include Thai language
@hmhealey hmhealey requested a review from larkox November 15, 2024 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2: Dev Review Requires review by a core commiter 3: QA Review Requires review by a QA tester Contributor do-not-merge/release-note-label-needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants