Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unit test for mobile draft #8363

Open
wants to merge 61 commits into
base: mobile-drafts
Choose a base branch
from
Open

Unit test for mobile draft #8363

wants to merge 61 commits into from

Conversation

Rajat-Dabade
Copy link
Contributor

Summary

Added unit test for mobile in draft PR: #8280

Ticket Link

https://mattermost.atlassian.net/browse/MM-61735

Checklist

  • Added or updated unit tests (required for all new features)
  • Has UI changes
  • Includes text changes and localization file updates
  • Have tested against the 5 core themes to ensure consistency between them.
  • Have run E2E tests by adding label E2E iOS tests for PR.

Release Note

NONE

Rajat-Dabade and others added 30 commits October 17, 2024 16:15
@Rajat-Dabade
refactor: started with draft, done until new tabs for draft
7a954e7
@Rajat-Dabade
refactor: change the query and added the screen for draft
bf64bce
@Rajat-Dabade
added condition for fetching draft for channel delete or not
d7e3aea
@Rajat-Dabade
refactor: added draft screen
421fdf2
@Rajat-Dabade
linter fixes
c32df46
@Rajat-Dabade
Added draft post component
1eefbde
@Rajat-Dabade
added avatar and header display name for the draft post list
6cb3094
@Rajat-Dabade
added channel info component
1dbe020
@Rajat-Dabade
channel info completed
978a8cb
@Rajat-Dabade
proper naming
f069326
@Rajat-Dabade
added image file markdown acknowledgement support
9b4d50f
@Rajat-Dabade
draft actions
743d994
@Rajat-Dabade
Fix the draft receiver in drafts
bf7767e
@Rajat-Dabade
separated send message handler
0aae855
@Rajat-Dabade
Done with send drafts
bf446e3
@Rajat-Dabade
done with delete drafts
cf37827
@Rajat-Dabade
change save to send draft
0a1fc59
@Rajat-Dabade
handle lengthy message with show more button
b7b5053
@Rajat-Dabade
done with persistent message edit, send and delete drafts
594f167
@Rajat-Dabade
added alert for sending message
ea46f34
@Rajat-Dabade
added update at time for the drafts
b895070
@mattermost-build
Merge branch 'main' into mobile-drafts
b93b340
@Rajat-Dabade
en.json extract fix
086ec82
@Rajat-Dabade
Updated dependencies for useCallback
98d58c3
@Rajat-Dabade
refactor: added drafts list to animated list
902e2ea
@Rajat-Dabade
added swipeable component and delete conformation for drafts
3fea445
@Rajat-Dabade
done with rendering of images in markdown for drafts
2607869
@Rajat-Dabade
en.json issue fixed
5e99dce
@Rajat-Dabade
fix en.json issue
d26155c
@Rajat-Dabade
refactor: en.json fix
c7e36be
@Rajat-Dabade Rajat-Dabade marked this pull request as ready for review November 26, 2024 13:45
@Rajat-Dabade Rajat-Dabade self-assigned this Nov 26, 2024
@Rajat-Dabade Rajat-Dabade added 2: Dev Review Requires review by a core commiter 3: QA Review Requires review by a QA tester labels Nov 26, 2024
enahum
enahum requested changes Dec 19, 2024
View reviewed changes
Copy link
Contributor

@enahum enahum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like this PR needs conflict resolution and to cover all the changes in the base PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@enahum enahum enahum requested changes

@larkox larkox Awaiting requested review from larkox

Assignees

@Rajat-Dabade Rajat-Dabade

Labels
2: Dev Review Requires review by a core commiter 3: QA Review Requires review by a QA tester release-note-none
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Rajat-Dabade @enahum @mm-cloud-bot @mattermost-build