Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrapped the searchbar container inside SafeAreaView #8402

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

PhillipRW03
Copy link

@PhillipRW03 PhillipRW03 commented Dec 10, 2024

Summary

Ticket Link

Checklist

  • Added or updated unit tests (required for all new features)
  • Has UI changes
  • Includes text changes and localization file updates
  • Have tested against the 5 core themes to ensure consistency between them.
  • Have run E2E tests by adding label E2E iOS tests for PR.

Device Information

This PR was tested on:

Screenshots

Release Note


@mattermost-build
Copy link
Contributor

Hello @PhillipRW03,

Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.

Per the Mattermost Contribution Guide, we need to add you to the list of approved contributors for the Mattermost project.

Please help complete the Mattermost contribution license agreement?
Once you have signed the CLA, please comment with /check-cla and confirm that the CLA check is green.

This is a standard procedure for many open source projects.

Please let us know if you have any questions.

We are very happy to have you join our growing community! If you're not yet a member, please consider joining our Contributors community channel to meet other contributors and discuss new opportunities with the core team.

@enahum
Copy link
Contributor

enahum commented Dec 12, 2024

What is the reason for doing this?

@enahum
Copy link
Contributor

enahum commented Dec 14, 2024

@PhillipRW03 if this is to solve the issue on the search screen I'm afraid is not the right way of doing it for a couple of reasons.

  1. this affects every screen where the component is used and will change the UI for unwanted results.
  2. The way the search bar is positioned in that screen is based on a complex animation scheme that determines the position based on the scroll offset and many more variables

I will encourage you to spend time on this to find the proper way of fixing the issue

Copy link
Contributor

@enahum enahum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as I mentioned in the comments, this does not address the real problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2: Dev Review Requires review by a core commiter 3: QA Review Requires review by a QA tester Contributor release-note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants