Update dependencies and upgrade to RN 0.76.5 #8421

enahum · 2024-12-17T13:50:10Z

Summary

Upgrade all dependencies (the app should be tested in its entirety) and upgraded to React Native 0.76.5, still blocked to switch to the new arch by the navigation library

Ticket Link

https://mattermost.atlassian.net/browse/MM-60562

Release Note

NONE

larkox

Some nitpicks here and there, but nothing really blocking.

larkox · 2024-12-17T17:17:08Z

app/components/channel_bookmarks/channel_bookmark/bookmark_icon.tsx

@@ -60,7 +60,7 @@ const BookmarkIcon = ({emoji, emojiSize, emojiStyle, file, genericStyle, iconSiz
            name='book-outline'
            size={22}
            color={theme.centerChannelColor}
-            style={genericStyle}
+            style={genericStyle as StyleProp<TextStyle>}


In several files we are doing this, and the prop is only used to then be casted. Shouldn't we change the type directly in the prop?

larkox · 2024-12-17T17:23:17Z

app/components/post_draft/uploads/index.tsx


    useEffect(() => {
        if (files.length) {
            containerHeight.value = CONTAINER_HEIGHT_MAX;
            return;
        }
        containerHeight.value = CONTAINER_HEIGHT_MIN;
-    }, [files.length > 0]);
+    }, [containerHeight, files.length]);


Nitpick:

If we create a new variable hasFiles, we might not run this effect so often, and may be slightly more intention revealing. (Not that this is neither hard to understand or has any performance issue though)

const hasFiles = Boolean(files.length); useEffect(() => { if (hasFiles) {...} ... }, [containerHeight, hasFiles]);

larkox · 2024-12-17T17:28:03Z

app/components/post_list/date_separator/index.tsx

@@ -13,7 +13,7 @@ import {typography} from '@utils/typography';

 type DateSeparatorProps = {
    date: number | Date;
-    style?: StyleProp<ViewStyle>;
+    style?: StyleProp<TextStyle>;


In order to make this type safe, you can use the Intersection utility type we have like this:

style?: StyleProp<Intersection<TextStyle, ViewStyle>>;

That way, we don't need the casting, and we make sure we don't pass styles that may create issues.

larkox · 2024-12-17T17:30:05Z

app/components/post_list/post_list.tsx

@@ -130,7 +130,7 @@ const PostList = ({
            return false;
        }
        return posts[0]?.id !== lastPostId;
-    }, [posts[0]?.id, lastPostId]);
+    }, [lastPostId, posts]);


Probably this memo is not needed at all (it is memoizing a boolean value and doing a pretty fast operation). But 0/5 on whether it is desirable to change it in this PR.

larkox · 2024-12-17T17:32:15Z

app/components/post_list/thread_overview/__snapshots__/thread_overview.test.tsx.snap

+            "cursor": undefined,
+          },
+        ]
+      }


A bit surprised of these snapshots changing. Do you know where is this change coming from?

this can be caused by the upgrade of react-native-gesture-handler library or the update to react-native or react, this is defo not done by us.

This is another reason why I think snapshots are silly.

larkox · 2024-12-17T17:33:08Z

app/hooks/useCollapsibleHeader.test.tsx

+    afterAll(() => {
+        // jest.resetAllMocks();


Is this no longer needed? If so, should we just remove it?

larkox · 2024-12-17T17:44:27Z

app/utils/errors.ts

@@ -70,15 +70,15 @@ export const getFullErrorMessage = (error: unknown, intl?: IntlShape, depth = 0)
        return `${message}; ${getFullErrorMessage(error.details, intl, depth + 1)}`;
    }

-    return message;
+    return message!;


What is causing us to need this? Same on line 81. We should add some default value instead of using the !.

rahimrahman

There are a lot of changes in here. I feel like in the future it is better to compartmentalize changes into smaller PRs. I see changes that correspond to react-native upgrade, and changes to linting errors, and anything else in between.

My $0.02.

rahimrahman · 2025-01-03T20:05:46Z

app/components/post_list/thread_overview/__snapshots__/thread_overview.test.tsx.snap

+            "cursor": undefined,
+          },
+        ]
+      }


This is another reason why I think snapshots are silly.

rahimrahman · 2025-01-06T15:40:57Z

app/components/announcement_banner/announcement_banner.tsx

@@ -114,7 +114,7 @@ const AnnouncementBanner = ({
            snapPoints: [1, snapPoint],
            theme,
        });
-    }, [theme.sidebarHeaderTextColor, intl.locale, renderContent, allowDismissal]);
+    }, [intl, allowDismissal, renderContent, theme]);


I'm guessing this (and others) is more of a lint error vs react-native upgrade?

rahimrahman · 2025-01-08T17:55:26Z

@yasserfaraazkhan ping. Can you do a smoke test on this? I see the E2E with iOS has passed, but can you check on Android?

There's a growing demand to get this through.

yasserfaraazkhan · 2025-01-08T18:55:58Z

@yasserfaraazkhan ping. Can you do a smoke test on this? I see the E2E with iOS has passed, but can you check on Android?

There's a growing demand to get this through.

Hi @rahimrahman
I'll work on android device. I've done the iOS device tests. (posted an update here)

yasserfaraazkhan · 2025-01-09T07:54:00Z

Executed iOS test cycle
Executed Android test cycle

Observed defect on android

https://mattermost.atlassian.net/browse/MM-62461

rahimrahman · 2025-01-09T13:54:59Z

Thanks for testing. I'm not as worried about the issue you found, whether it's caused by this or something completely different since it's not blocking. But I will take a look at it nevertheless.

rahimrahman · 2025-01-09T21:40:43Z

/update-branch

lindalumitchell · 2025-01-10T06:20:54Z

@rahimrahman @yasserfaraazkhan I tried installing from the PR build as posted here and also the previously built one here, but in both cases the app doesn't launch successfully. It installs, and I tap the icon to launch, it flashes/blurs the screen for a moment, then it returns to the state before I tapped. I can't get the app to launch. Am I missing something obvious here? Are others able to install and launch the PR build for iOS?

I see this issue on both iPhone 13 Pro Max with iOS 18.2 and also iPad Pro 11-inch with iOS 18.1.1 (tried twice with each).

iPhone-Mm-doesnt-launch.mp4

yasserfaraazkhan · 2025-01-10T06:30:23Z

Hi @lindalumitchell @rahimrahman
I think its an issue with latest iOS. I had tried it on simulator with 17.5 iOS version and saw the same. It works on 17.1, 17.2 version.

It might be blocker for latest versions.

rahimrahman · 2025-01-10T07:27:35Z

@lindy65 @yasserfaraazkhan I have this running on iPhone 15 simulator on 17.5 and iPhone 16 Max simulator on 18.2. I will try in the AM again on real devices. I have devices running on 17.x and 18.2.1.

I just updated the branch with main. I'm going to build the app again with the latest merged into it. Don't think it will make a difference, but let's see what happens here.

lindalumitchell · 2025-01-10T20:13:47Z

Thanks @rahimrahman , I'm afraid you're right -- I tried on the new PR build and the issue is still there and the app won't launch.

lindalumitchell · 2025-01-10T23:55:45Z

(I added myself as a reviewer to help keep this on my radar next week. For anyone reading this, I'll be doing smoke tests on iPad to round out the testing.)

rahimrahman · 2025-01-11T16:56:28Z

@lindalumitchell @yasserfaraazkhan I think I found the culprit and pushed the fix. It is building. I will verify it with my devices (18.2, I appreciate the testing on this and catching the issue. It is not a problem when doing an install on top of older version, but it is a problem on new install (hard install).

It works on iPhone 15 simulator 17.5.

rahimrahman · 2025-01-11T18:55:11Z

This is my iPhone X running 16.x. So probably not a valid test. But for the record.

RPReplay_Final1736620562.MP4

enahum added 10 commits December 17, 2024 21:45

update dev deps

00ba6d6

partial update dependencies

7250a61

update watermelondb

44a7d8c

update rn to 0.76.5, expo to 52.0.18 and others

9152700

upgrade android firebase

505b02c

upgrade detox deps

5e97d34

fix package-lock.json

17eb8ef

update emm and paste-input

82d39a2

update turbo-log

ca144a0

update network library

1ba1dc0

enahum added 2: Dev Review Requires review by a core commiter 3: QA Review Requires review by a QA tester labels Dec 17, 2024

enahum requested review from larkox, rahimrahman and yasserfaraazkhan December 17, 2024 13:50

mm-cloud-bot added release-note-none labels Dec 17, 2024

fix tests

f9efe04

larkox approved these changes Dec 17, 2024

View reviewed changes

review feedback

027cbe3

yasserfaraazkhan added the E2E iOS tests for PR Run iOS E2E Detox tests label Jan 5, 2025

github-actions bot removed the E2E iOS tests for PR Run iOS E2E Detox tests label Jan 5, 2025

fix Keyboard blocking signIn button

f92fec0

yasserfaraazkhan added the E2E iOS tests for PR Run iOS E2E Detox tests label Jan 6, 2025

github-actions bot removed the E2E iOS tests for PR Run iOS E2E Detox tests label Jan 6, 2025

Fall back to iphone 14 iOS 17.2 simulator as app crashes on iOS 17.4

b8eccc3

yasserfaraazkhan added the E2E iOS tests for PR Run iOS E2E Detox tests label Jan 6, 2025

github-actions bot removed the E2E iOS tests for PR Run iOS E2E Detox tests label Jan 6, 2025

yasserfaraazkhan added the Build Apps for PR Build the mobile app for iOS and Android to test label Jan 6, 2025

rahimrahman approved these changes Jan 6, 2025

View reviewed changes

rahimrahman added the E2E iOS tests for PR Run iOS E2E Detox tests label Jan 7, 2025

github-actions bot removed the E2E iOS tests for PR Run iOS E2E Detox tests label Jan 7, 2025

yasserfaraazkhan added Build App for iOS Build the mobile app for iOS and removed Build Apps for PR Build the mobile app for iOS and Android to test labels Jan 9, 2025

yasserfaraazkhan approved these changes Jan 9, 2025

View reviewed changes

rahimrahman added this to the v2.24.0 milestone Jan 9, 2025

amyblais modified the milestones: v2.24.0, v2.25.0 Jan 9, 2025

Merge branch 'main' into deps

2603760

rahimrahman added Build Apps for PR Build the mobile app for iOS and Android to test and removed Build App for iOS Build the mobile app for iOS labels Jan 10, 2025

lindalumitchell self-requested a review January 10, 2025 23:55

changes in deleteCredentialsForServer is causing a crash

0d07ce9

rahimrahman added Build Apps for PR Build the mobile app for iOS and Android to test and removed Build Apps for PR Build the mobile app for iOS and Android to test labels Jan 11, 2025

withOptions x2 clearly is wrong

284271d

rahimrahman added Build Apps for PR Build the mobile app for iOS and Android to test and removed Build Apps for PR Build the mobile app for iOS and Android to test labels Jan 11, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update dependencies and upgrade to RN 0.76.5 #8421

Update dependencies and upgrade to RN 0.76.5 #8421

enahum commented Dec 17, 2024

larkox left a comment

larkox Dec 17, 2024

larkox Dec 17, 2024

larkox Dec 17, 2024

larkox Dec 17, 2024

larkox Dec 17, 2024

enahum Dec 18, 2024

rahimrahman Jan 3, 2025

larkox Dec 17, 2024

larkox Dec 17, 2024

rahimrahman left a comment

rahimrahman Jan 3, 2025

rahimrahman Jan 6, 2025

rahimrahman commented Jan 8, 2025

yasserfaraazkhan commented Jan 8, 2025

yasserfaraazkhan commented Jan 9, 2025 •

edited

Loading

rahimrahman commented Jan 9, 2025

rahimrahman commented Jan 9, 2025

lindalumitchell commented Jan 10, 2025 •

edited

Loading

yasserfaraazkhan commented Jan 10, 2025

rahimrahman commented Jan 10, 2025

lindalumitchell commented Jan 10, 2025

lindalumitchell commented Jan 10, 2025

rahimrahman commented Jan 11, 2025

rahimrahman commented Jan 11, 2025

Update dependencies and upgrade to RN 0.76.5 #8421

Are you sure you want to change the base?

Update dependencies and upgrade to RN 0.76.5 #8421

Conversation

enahum commented Dec 17, 2024

Summary

Ticket Link

Release Note

larkox left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rahimrahman left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rahimrahman commented Jan 8, 2025

yasserfaraazkhan commented Jan 8, 2025

yasserfaraazkhan commented Jan 9, 2025 • edited Loading

rahimrahman commented Jan 9, 2025

rahimrahman commented Jan 9, 2025

lindalumitchell commented Jan 10, 2025 • edited Loading

yasserfaraazkhan commented Jan 10, 2025

rahimrahman commented Jan 10, 2025

lindalumitchell commented Jan 10, 2025

lindalumitchell commented Jan 10, 2025

rahimrahman commented Jan 11, 2025

rahimrahman commented Jan 11, 2025

yasserfaraazkhan commented Jan 9, 2025 •

edited

Loading

lindalumitchell commented Jan 10, 2025 •

edited

Loading