Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding telemetry #201

Merged
merged 9 commits into from
Jul 8, 2024
Merged

Adding telemetry #201

merged 9 commits into from
Jul 8, 2024

Conversation

jespino
Copy link
Member

@jespino jespino commented Jun 6, 2024

Description

This PR adds telemetry to the plugin. It sends a list of events, but stills needs to add the metrics for the current settings.

server/api_channel.go Outdated Show resolved Hide resolved
server/configuration.go Show resolved Hide resolved
server/api_channel.go Outdated Show resolved Hide resolved
server/api_channel.go Outdated Show resolved Hide resolved
Copy link

@ifoukarakis ifoukarakis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a couple of comments.

server/api_channel.go Outdated Show resolved Hide resolved
server/api_channel.go Outdated Show resolved Hide resolved
@jespino jespino requested a review from ifoukarakis July 4, 2024 13:44
@jespino
Copy link
Member Author

jespino commented Jul 4, 2024

@ifoukarakis thanks, addressed your suggestions.

Copy link

@ifoukarakis ifoukarakis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving after checking data on test schema in destination.

server/api_channel.go Outdated Show resolved Hide resolved
server/plugin.go Outdated Show resolved Hide resolved
@jespino jespino requested a review from crspeller July 8, 2024 16:18
@crspeller crspeller merged commit 606e2b7 into mattermost:master Jul 8, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants