Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat] updating the rudder key using the plugins key environment variable #222

Merged
merged 1 commit into from
Jul 15, 2024

Conversation

phoinixgrr
Copy link
Contributor

Copy link

@ifoukarakis ifoukarakis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: shouldn't we be using copilot rather than plugin-ai for naming?

@phoinixgrr
Copy link
Contributor Author

nit: shouldn't we be using copilot rather than plugin-ai for naming?

@ifoukarakis Refers to mattermost-plugin-ai plugin , should be easier to be correlated with the actual usage.
We can change it if you think that is needed though.

Let me know.

@ifoukarakis
Copy link

nit: shouldn't we be using copilot rather than plugin-ai for naming?

@ifoukarakis Refers to mattermost-plugin-ai plugin , should be easier to be correlated with the actual usage. We can change it if you think that is needed though.

Let me know.

I'm ok with either. mattermost-plugin-ai is the name of the repo, but README.md mentions Mattermost Copilot Plugin, so I was thinking if there's an agreed naming so that we're consistent. Again, that's nitpicking, so not a blocker.

@phoinixgrr phoinixgrr merged commit c708ecf into master Jul 15, 2024
5 checks passed
@phoinixgrr phoinixgrr deleted the CLD-8054-rudder-key-revisit branch July 15, 2024 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants