[GH-669]: Add org selector to create issue modal #675

thoratvinod · 2023-05-05T17:59:34Z

Summary

Added endpoints for listing organizations and listing repositories for specific organizations.
Added an additional selector for selecting organizations, and made related changes in actions & reducers.

Screenshots

If organizations are present:

If no organization is present:

Ticket Link

Fixes #669

mattermost-build · 2023-05-05T17:59:43Z

Hello @thoratvinod,

Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.

mickmister

Thanks for this great contribution @thoratvinod! I have some comments regarding the GitHubOrg config setting, and some other suggestions. Overall looking good 👍

webapp/src/reducers/index.js

webapp/src/client/client.js

webapp/src/components/github_repo_selector/github_repo_selector.jsx

server/plugin/api.go

…r.jsx Co-authored-by: Michael Kochell <[email protected]>

webapp/src/components/github_repo_selector/github_repo_selector.jsx

…r.jsx Co-authored-by: Michael Kochell <[email protected]>

codecov-commenter · 2023-05-20T08:03:13Z

Codecov Report

Attention: 98 lines in your changes are missing coverage. Please review.

Comparison is base (8cf783f) 15.49% compared to head (3c5d9cd) 15.27%.
Report is 2 commits behind head on master.

Files	Patch %	Lines
server/plugin/api.go	2.00%	98 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #675      +/-   ##
==========================================
- Coverage   15.49%   15.27%   -0.23%     
==========================================
  Files          15       15              
  Lines        5737     5833      +96     
==========================================
+ Hits          889      891       +2     
- Misses       4806     4900      +94     
  Partials       42       42

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

mickmister

Thanks for this contribution @thoratvinod 👍 I have one more request to avoid returning the current user's login in the case where we have the GitHubOrg config setting set. Otherwise LGTM

server/plugin/api.go

Co-authored-by: Michael Kochell <[email protected]>

mickmister · 2023-07-05T20:03:28Z

@thoratvinod Thank you for your patience on this

hanzei · 2023-07-06T05:03:30Z

@calebroseland @mgdelacroix Gentle reminder to review this PR

mattermost-build · 2023-07-17T01:03:13Z

This PR has been automatically labelled "stale" because it hasn't had recent activity.
A core team member will check in on the status of the PR to help with questions.
Thank you for your contribution!

Kshitij-Katiyar · 2023-10-04T10:19:02Z

@thoratvinod Can you please fix the merge conflicts.

hanzei · 2023-11-09T09:10:26Z

@thoratvinod Do you want to continue working on this issue?

thoratvinod · 2023-11-15T03:06:04Z

@hanzei yes, I want to continue this, will take 2-3 weeks to get back on this. Is that fine?

hanzei · 2023-11-16T09:56:09Z

Sure, we are not in a hurry. Thanks for coming back to the PR @thoratvinod 👍

hanzei · 2023-12-05T20:38:25Z

Thanks for updating the PR @thoratvinod 👍

CI complains about two errors:

/home/runner/work/mattermost-plugin-github/mattermost-plugin-github/webapp/src/reducers/index.js
Error:   243:5  error  'yourPrsDetails' is not defined   no-undef
Error:   244:5  error  'yourAssignments' is not defined  no-undef

I suppose the changes in #626 caused actions to not longer exist.

mattermost-build · 2023-12-16T01:02:59Z

This PR has been automatically labelled "stale" because it hasn't had recent activity.
A core team member will check in on the status of the PR to help with questions.
Thank you for your contribution!

thoratvinod · 2023-12-28T04:25:02Z

Hey @hanzei , @mickmister ,
I've got some personal stuff going on and won't be able to keep up with this issue. Thanks for understanding

mickmister · 2024-01-10T19:59:17Z

Thanks for your work on this @thoratvinod! I'm closing for now and mentioned this PR on the linked ticket

Vinod Thorat added 4 commits May 5, 2023 16:43

backend changes, added getOrgs and getReposByOrgs endpoints

f84fec3

front-end changes

5960f1d

Removed log statements

9225660

race condition

862cc6b

thoratvinod requested a review from hanzei as a code owner May 5, 2023 17:59

mattermost-build added the Contributor label May 5, 2023

thoratvinod marked this pull request as draft May 5, 2023 18:00

have changed default org selector option

7ffdd08

thoratvinod marked this pull request as ready for review May 6, 2023 04:08

thoratvinod changed the title ~~GH-669: Improve performance of create issue modal~~ [GH-669]: Improve performance of create issue modal May 6, 2023

hanzei requested review from mickmister and removed request for hanzei May 9, 2023 19:49

hanzei added 2: Dev Review Requires review by a core committer 3: QA Review Requires review by a QA tester labels May 9, 2023

mickmister suggested changes May 10, 2023

View reviewed changes

thoratvinod and others added 2 commits May 11, 2023 22:08

Update webapp/src/components/github_repo_selector/github_repo_selecto…

cc78ff5

…r.jsx Co-authored-by: Michael Kochell <[email protected]>

Addressed coments

cbf8607

mickmister changed the title ~~[GH-669]: Improve performance of create issue modal~~ [GH-669]: Add organization selector to create issue modal May 17, 2023

mickmister changed the title ~~[GH-669]: Add organization selector to create issue modal~~ [GH-669]: Add org selector to create issue modal May 17, 2023

mickmister reviewed May 17, 2023

View reviewed changes

webapp/src/components/github_repo_selector/github_repo_selector.jsx Outdated Show resolved Hide resolved

thoratvinod and others added 2 commits May 17, 2023 21:15

Update webapp/src/components/github_repo_selector/github_repo_selecto…

86f981e

…r.jsx Co-authored-by: Michael Kochell <[email protected]>

Addressed comment

8b2675c

thoratvinod requested a review from mickmister May 20, 2023 08:07

Fixed lint errs

5402518

hanzei requested a review from mgdelacroix May 21, 2023 07:28

mickmister suggested changes May 22, 2023

View reviewed changes

server/plugin/api.go Outdated Show resolved Hide resolved

server/plugin/api.go Show resolved Hide resolved

server/plugin/api.go Outdated Show resolved Hide resolved

thoratvinod and others added 2 commits May 22, 2023 21:34

Update server/plugin/api.go

a4f1c1e

Co-authored-by: Michael Kochell <[email protected]>

addressed comment

8ab35c5

mickmister requested a review from DHaussermann July 5, 2023 20:03

mickmister removed the Lifecycle/1:stale label Jul 5, 2023

mattermost-build added the Lifecycle/1:stale label Jul 17, 2023

Kshitij-Katiyar added this to the v2.3.0 milestone Oct 5, 2023

hanzei removed request for calebroseland, mgdelacroix and DHaussermann October 10, 2023 07:40

hanzei added the Awaiting Submitter Action Blocked on the author label Oct 10, 2023

hanzei added Lifecycle/2:inactive and removed Lifecycle/1:stale labels Nov 9, 2023

hanzei removed 2: Dev Review Requires review by a core committer 3: QA Review Requires review by a QA tester labels Nov 30, 2023

Merge branch 'master' into issue-669

3c5d9cd

hanzei removed the Lifecycle/2:inactive label Dec 5, 2023

mattermost-build added the Lifecycle/1:stale label Dec 16, 2023

mickmister mentioned this pull request Jan 10, 2024

Improve performance of Create Issue modal repository selector #669

Open

mickmister closed this Jan 10, 2024

mattermost-build removed the Awaiting Submitter Action Blocked on the author label Jan 10, 2024

cyrusjc mentioned this pull request Apr 10, 2024

[GH-669]: "Add org selector to create issue modal" thoratvinod:issue-669 #766

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[GH-669]: Add org selector to create issue modal #675

[GH-669]: Add org selector to create issue modal #675

thoratvinod commented May 5, 2023 •

edited

Loading

mattermost-build commented May 5, 2023

mickmister left a comment

codecov-commenter commented May 20, 2023 •

edited

Loading

mickmister left a comment

mickmister commented Jul 5, 2023

hanzei commented Jul 6, 2023

mattermost-build commented Jul 17, 2023

Kshitij-Katiyar commented Oct 4, 2023

hanzei commented Nov 9, 2023

thoratvinod commented Nov 15, 2023 •

edited

Loading

hanzei commented Nov 16, 2023

hanzei commented Dec 5, 2023

mattermost-build commented Dec 16, 2023

thoratvinod commented Dec 28, 2023

mickmister commented Jan 10, 2024

[GH-669]: Add org selector to create issue modal #675

[GH-669]: Add org selector to create issue modal #675

Conversation

thoratvinod commented May 5, 2023 • edited Loading

Summary

Screenshots

Ticket Link

mattermost-build commented May 5, 2023

mickmister left a comment

Choose a reason for hiding this comment

codecov-commenter commented May 20, 2023 • edited Loading

Codecov Report

mickmister left a comment

Choose a reason for hiding this comment

mickmister commented Jul 5, 2023

hanzei commented Jul 6, 2023

mattermost-build commented Jul 17, 2023

Kshitij-Katiyar commented Oct 4, 2023

hanzei commented Nov 9, 2023

thoratvinod commented Nov 15, 2023 • edited Loading

hanzei commented Nov 16, 2023

hanzei commented Dec 5, 2023

mattermost-build commented Dec 16, 2023

thoratvinod commented Dec 28, 2023

mickmister commented Jan 10, 2024

thoratvinod commented May 5, 2023 •

edited

Loading

codecov-commenter commented May 20, 2023 •

edited

Loading

thoratvinod commented Nov 15, 2023 •

edited

Loading