Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MM-356] Add feature to subscribe to release and workflow events #765
[MM-356] Add feature to subscribe to release and workflow events #765
Changes from 5 commits
5dc7a26
e5c50fd
ec69c2d
32882a1
28cdb5a
0d050ac
612a259
96ed032
ab37277
f9034c4
b629477
e5385bc
9e536e7
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1/5 I think we should support (or require) a
workflow
parameter here (and maybe supportjob
parameter as well). Maybe we can support both individual workflows and all workflow cases:Just the
ci
workflowAll workflows
@hanzei What do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense to me 👍
Limiting the notifications to a specific branch seems like a common use case. Can we include that in there as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mickmister Are you suggesting here to add a subscription on the basis of the workflow name, which is
ci
in the above case, or have I misunderstood the comment?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mickmister @hanzei For the above case, what should be the slash command format? Should we keep something like:
/github subscriptions add owner/repo pulls,workflows:branch-b1,b2;name-n1,n2;job-j1,j2
? Please let me know if you have any better suggestions for the above case.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
subscriptions add
feature is quite overloaded at this point. Adding more complexity on top of it may not be the best thing to do. Created a ticket for breaking this out of the command #780Mainly thinking of the complexity of the
job
parameter there. I'm thinking we should avoid thejob
parameter, since those jobs may not belong to all workflows. Then it's up to the actions workflow developer in that project to structure the workflows in a way to be something to subscribe to.